From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 384A14A99B3 for ; Fri, 11 Sep 2026 18:32:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789151525; cv=none; b=NfzvVURlcWmLjhyuLa4bjpOeKhNkLX+x9Djp7Bnvq9Z8mB/q/8JBsW+uib42xdWkKywIzfk+ZLMEQFVRRLMaalUqVkIEirxkuASe4Dj20LzniFjriCRUm3FPtJ1VZMnHnFXUNH8V7owpFf2/drNunz1Sr3A/XKe4837ZABh2138= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789151525; c=relaxed/simple; bh=6cBl9YoGoA83gQlWtx1nBAyvkveypxIuXeuy2M875mw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i37ypDZWIO3A7Ozr98+h5nYB50PLCY8zFfQ41hSZTo3WG+IV17qo8KAP2OJKiSkX3Off6f/QVAeW2qmgwnnWRdPLjd64VyycMI/V4tsPi1v2Yg+CdLcUuCzqJBLIUyAT7MmEuYHAWe33MZa+ZCOfyEWQ5qxiIkVtzjDo1Wi4HsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=f5GBk6fF; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="f5GBk6fF" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-86309e1a213so627473b3a.0 for ; Fri, 11 Sep 2026 11:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1789151523; x=1789756323; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=647PeDACYFGwHy56KY6C8DNyZ6c/Uo5FYVw3HHMYVSA=; b=f5GBk6fFr3x/guSHAcYDCje1xOw8IeDCzr0jwB0gNRXooXc8AScK3IlipaXWBvY17A u30QvjIR8bmn8kxKXzOVsW+LA3S504JLCcllVu6g1/Xjx62Grn2rOFEMgAl3CVV/U5YZ krbfMFF2GPgse8Ow0F4d5/rtJek2P+piaVLfe022/b8y2RjntNhy8pL+1C0+FWmoLZmU 83lbsx5duoScL3EheD8YdZy7o1inCnO0+7bdp8X6wRPAFdTdYOLBkK+ob5zSnPuwh266 ftpeqqme7OF7orvSF36+Ee95q0jZp8s5wQVT5SnRZww9b/dYatFdrYR4iOAgOCiQMdG7 ye5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789151523; x=1789756323; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=647PeDACYFGwHy56KY6C8DNyZ6c/Uo5FYVw3HHMYVSA=; b=Hp687BpqaHCaiIbxgfkQVxjpF8wHGpPF1Fh4Z8CG7Ugcdzn22maORkWaQuqu0H4oGB FHBPTx70fyyNL3Amw9dL5h1gsm4LIzx2PjW7RM79OmXN4d/cJwXNEf837k5FLWNIgMIx Gh5oU4TmghLoOP5+UyE5Cri+C3V/CMoAbqp3pZVvrMd83VgBH8cm3MV4vaVQPGvlH6G+ TZYbnJhZnHs4stawJMeGeh/ckQol5ZGVvhzExRIAHAlB+0GokBv99w3tHlciRSORnKqq BWJtX4l61swrkbb8ChudfdXXMvsDtUtuvo5IBo0tIqZ/tknP/kM5VmvXwpvTTGIHaTMI vz+w== X-Forwarded-Encrypted: i=1; AKwUvBwqyZbynLGkmVmU8pC4woH6tmY3/qlb7LUmanYXiD/wYo1mHjcOmiEtUW2HcC5wVSYDdAs2eTSqhmPyyo0=@vger.kernel.org X-Gm-Message-State: AFuF++nclnz+sPs1IOAqFedKDYoWSUngMSuC+a+N33kZ3cI9pP6Y89VW W0+uKZ90Hei8AeMvZmNxzUEjklHZJOvEyWqSo0gC9S+Ztsen2nDXJ6wGNvlBNOBr8w== X-Gm-Gg: AYBFou0WjvwBIpFjdxJsvEhZd39Oj5/V1/i8D+T4qEO6U59oeE3hVlSWOqUpGvvzQaT Nr5L1qeDtVdOzkGVM0ro2QbruYifR/Iy5QScaWAQMXICLPxcG5idhemrB+mahMCjoA8s4WYqnOC g+emPJopmGZ4y4F8/6snlebJPrVQe7lQpUVYBx3+WuMXpFwFEO553EIt44IqfY4F1jdv51IIgEX cc2jDGPHTOQ/F7AC3SL+o/EeG4D+ImU8XL2q4TbX+Zg+tqdOZMuTRlchPK/YT/nkpiqFldUHMS5 IJFDxGMZdfRqpQ/6+8TLqE6Y05RKipxYFzUjXhRulXO+0lCGZHIdTRNZLekvuhGQjMGrrqwTLTF hDR+5SZ/lk0MyTh91dPbMssSMNisZFaO9KcuUdxq7Jr2VQ1DrOkSPpd/Cwu49Sv5VziiR3OYJ4h U0GGObc1tHuyOpPD+T8Sp3on6bGOFMj9NhtDLTsw+iZsGl6BDLiKdbIU1bP01vnunslUt/zB1+F Wvv1Zg6L90UgbXDHfzWJgAv/5QubERd0Vhk36PZj65+1O0bwG4= X-Received: by 2002:a05:6a20:4308:b0:3c4:3767:adb2 with SMTP id adf61e73a8af0-3daed46ab05mr10698355637.1.1789151522711; Fri, 11 Sep 2026 11:32:02 -0700 (PDT) Received: from google.com (192.150.203.35.bc.googleusercontent.com. [35.203.150.192]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc4c657156bsm1621771a12.21.2026.09.11.11.32.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 11:32:01 -0700 (PDT) Date: Fri, 11 Sep 2026 18:31:51 +0000 From: David Matlack To: Bjorn Helgaas Cc: kexec@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Adithya Jayachandran , Alexander Graf , Alex Williamson , Bjorn Helgaas , Chris Li , David Rientjes , Jacob Pan , Jason Gunthorpe , Jonathan Corbet , Josh Hilke , Leon Romanovsky , Lukas Wunner , Mike Rapoport , Parav Pandit , Pasha Tatashin , Pranjal Shrivastava , Pratyush Yadav , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Vipin Sharma , William Tu , Yi Liu Subject: Re: [PATCH v8 08/12] PCI: liveupdate: Adopt ACS controls in incoming preserved devices Message-ID: References: <20260728221007.2098560-9-dmatlack@google.com> <20260910235149.GA364189@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260910235149.GA364189@bhelgaas> On 2026-09-10 06:51 PM, Bjorn Helgaas wrote: > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > index 77b17b13ee61..22001bdf4c97 100644 > > --- a/drivers/pci/pci.c > > +++ b/drivers/pci/pci.c > > @@ -34,6 +34,8 @@ > > #include > > #include > > #include > > + > > +#include "liveupdate.h" > > #include "pci.h" > > > > DEFINE_MUTEX(pci_slot_mutex); > > @@ -1008,6 +1010,9 @@ void pci_enable_acs(struct pci_dev *dev) > > bool enable_acs = false; > > int pos; > > > > + if (!pci_liveupdate_enable_adopted_acs_controls(dev)) > > + return; > > Ugh. The asymmetry between pci_save_state(), which does nothing > ACS-related, and pci_restore_state(), which enables it, is sort of > sketchy to begin with. > > The command-line parsing in this path feels like kind of a wart (not > that you're touching it). > > It just seems like this path is already hard to analyze, and > liveupdate is making it harder. > > If we could save/restore the ACS state around the reset, wouldn't that > solve this without any liveupdate specials here? Yeah that would simplify the liveupdate support greatly. Let me work on that for v9.