From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E0EB40244D for ; Fri, 11 Sep 2026 18:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789153026; cv=none; b=sQRL7m0smly/ri7Mv8Tuole94nSw9giG/hQY/hsfeftKzJ7S8xrwikgCC8fFEATP9tqdfjovIc+TuvLw58KAzlA6QuptB1lmPCHUJfIjlZmFDbWLLEAFHtw0Vf5nw+SooYWL27JBk7OgqTA9iqwvZ05BXo265Wb71nlTKw6jcwQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789153026; c=relaxed/simple; bh=L6rh7PbU0UFjpOX2cNRwoGSW2b55d7SIpmhWyxZe2jU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EBzMSNcpvALZwHi/UsLRuwbRgkrSL0hrubrU+pk5nC6LY0tZKTlpkZaH+6UwidDFSshJAUt6Xku98OvEe0qAMyh41hvXs5u8RYHiSMz5wJUiqAC1/GvTxdBVC5roZ7Tnx1hiqoaenTwOztEHsmIkDtzoNz3VfJwBEcGu1qFbWJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=jnWmsfDH; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="jnWmsfDH" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-4843c2790ccso90917f8f.1 for ; Fri, 11 Sep 2026 11:57:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1789153022; x=1789757822; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Hh4sVlhxU5dBVP/3K7psJppy2n4LZjrwVn2yp2aqAe0=; b=jnWmsfDHjbwFsI/w5LaETScW3g2GoWP8DH3MNQ39LInxEQ45K9gykyqpHXNMDCvNdn oK1+M1kU+Dkx8M6mvJydhJqeupXg2bCK/j7tZdrpxAzZwwcefG0mho6WaSD8FKW7OEaI 5HMu2LlpfcBle6t2IDRZ0q1Qs0bhBXsgxm0OsZzrLanVQgSaNIpAeW3pstCN466taBDI faEQp/aYTkWnBarQnFww1JSwnLD8r9dFs59GCVpH4calW7DzRgi5g47aRzOcbKNAG3uB 8+T+5ArgFk9NgnfiV0XumTkidaW1eDExFDJxSG0qBHLQ6STsymzLfJJc0gK6updgxX1I OGtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789153022; x=1789757822; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Hh4sVlhxU5dBVP/3K7psJppy2n4LZjrwVn2yp2aqAe0=; b=GHU2Y4qcFN3AdoRbb7l8inODlgepDgl/RewB0GvAMYFxX7dPHlk4NQFRXw7E00VMEZ fVplMQzvEWOizBAjOJa90J4u8yGI3+Y18Vi+ZsgdQk80bhpGZsBFYEVbVxxE8dLEW1Wj 49ivk5mD4DbcYnC245l3yoW3YCCP1TRw3FrU0eMKJMMtH9DHW7e40g5xxGYEA8vP57OM HIA7TIIzbRw348u5Za9daTckynIc0+C9pPSU6yaGiV0Tm/J+OQ9JcDwI9U+yGwliaPaV 5H4un/trkkKdKoqEh9pjQOtD+qsTqdSg9ID+bvHDplgXODYzh6k96razvAB9BqePJlYt WZPA== X-Forwarded-Encrypted: i=1; AKwUvBwAbviZobsSq1qSbRTnySH3OetXN98UPmaSkpBLojlxiVM9bj34lV7lYFTUPi3cwZoWGg8Qrchd1k81afY=@vger.kernel.org X-Gm-Message-State: AFuF++kw9kIJQFYuIKL9O9RTv+LYImWV3+N0Jgs3yxd7f8fhFTuCfB1y 2hqNyhwkpJ8FmjP1yt8R7WapjKu44pSvXoQh7e4Kd7sKGD61Rt46wPzryOtqSa0DBEc= X-Gm-Gg: AYBFou3TIZALIFGip5a+8eS1L4+e0pHnEhEH3b4h0nYUHflhWcYumkI+3nuhLVTSefs jVIlZ487bmQyDcd0zObnEr9xCR3Bx/9fQc6d9HnWIsQ+ZDZF2SuQphUydnKkdRnLDnpqLVMUGlW BG1s02Jh4FWYqYiwC0WtXUu4ajO4oaEhXiM2GXFLXXpkjezog5aJhguZ1KSWKnbdDyEzR/jcNaE 0g4IQ1HmM5rX6Obi7xGeitGLlVx7/ymn09Y+GGk/iZXEbBoZvaWgvduXl31zN/jwtc3Iyhc/yNL Mxd5ePjtA6arHR/+vhfIdVfFhZWupkuCVe1pAEvlTzcpbWTFYdIgOvmcSiXvTHP3Bj5kDEZSSVh zBRsaoCuOtmb7x0uAppOPCJSxcMX10UyB52+EgNch9xHC44cbZ3kv5FoKUi0crOEL0UNBO7d53A vDlS/4JeTXjOtYsGhxWVySpjFdSbqaNg57EqZu693DlWWabbzO30SunGBCXFYAC3urHHRn/m8RO 8Qd X-Received: by 2002:a5d:5f49:0:b0:485:b169:54fd with SMTP id ffacd0b85a97d-486eb1d388cmr12205373f8f.4.1789153022414; Fri, 11 Sep 2026 11:57:02 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-486eb2ed0fbsm7924090f8f.3.2026.09.11.11.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 11:57:01 -0700 (PDT) Date: Fri, 11 Sep 2026 20:57:00 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Bartosz Golaszewski Cc: Thara Gopinath , Herbert Xu , "David S. Miller" , Stanimir Varbanov , Eneas U de Queiroz , Kuldeep Singh , Eric Biggers , Demi Marie Obenour , Bjorn Andersson , Konrad Dybcio , linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, brgl@kernel.org Subject: Re: [PATCH v7 11/12] soc: qcom: add core driver for the Qualcomm Crypto Engine Message-ID: References: <20260910-qce-fix-self-tests-v7-0-cdbd2718af14@oss.qualcomm.com> <20260910-qce-fix-self-tests-v7-11-cdbd2718af14@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="joivlbaqnu5rwgfx" Content-Disposition: inline In-Reply-To: <20260910-qce-fix-self-tests-v7-11-cdbd2718af14@oss.qualcomm.com> --joivlbaqnu5rwgfx Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v7 11/12] soc: qcom: add core driver for the Qualcomm Crypto Engine MIME-Version: 1.0 Hello Bart, On Thu, Sep 10, 2026 at 03:00:52PM +0200, Bartosz Golaszewski wrote: > +#include > +#include Please don't add new includes for . Either rely on to provide of_device_id (my preference), or include . > [...] > +static const struct of_device_id qce_core_of_match[] = { > + { .compatible = "qcom,crypto-v5.1", }, > + { .compatible = "qcom,crypto-v5.4", }, > + { .compatible = "qcom,qce", }, > + {} Please drop the commas for before the closing }. Also in my cleanups around these device_id structs I used { } with a space in-between the braces. Just today I got some opposition to that[1], but in combination with the spacing in the non-empty initializers I still prefer { } over {}. > +}; > +MODULE_DEVICE_TABLE(of, qce_core_of_match); Best regards Uwe [1] https://lore.kernel.org/all/45a04396-c6c1-41f4-ace8-0ee0ccbc50ad@acm.org/ --joivlbaqnu5rwgfx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqkTvoACgkQj4D7WH0S /k5B8ggArcjj6bNgFKC+jk74PuEqWNqnxp83hYq4YhCQ4nkN5btdBCTUHpvce57Y tBLNeoqp+ogRIJDvTqZwBjB+3Gpn7Xaz5G0oW7tfOPbfQYrS02tXJbN4iR5v85Sd 9PrXSAOEjomDiJ5iCToEvNzs/NHzabEZ+IH721yYfCBsiUvd+nLYePUdzq9ICGij zaKxkNLMiyiV5WtnuF19WfPsemVF8etJYThIiGfQ9vzFWAIRU2fgEW1XghxIC2/C vVzujCNLI5VkWqgZDuB1UtSlLshJ+ZtT87nGphi1LWV9KVabXtsfPTdTFnHHyx8U aAQtSnfF0SdPJaeWJMLNMGNHWcvaeg== =3iTu -----END PGP SIGNATURE----- --joivlbaqnu5rwgfx--