From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8D4BEED8 for ; Sat, 12 Sep 2026 00:02:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789171356; cv=none; b=fSk/mMYDGufgzaqY+2ZCOJBUN+i2qagseb4LdnOtadWWLQ/3u1rc3JuUTBL5ktFIvq270qksXABcKKpzIghOfZ7lprxxl8/WSld8VEM5TqiafyYG2hMVrt3lZygDpO4uFPvzhPTyP04Y8o0amfjyYG5P+qV8HunpAVU9DNy5Ypw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789171356; c=relaxed/simple; bh=8/eHJLDCC1bgnSg4S6WmtVg2N+g/yx6dDLMOK09FGHs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TzivQabLW//Zo4BrOlV9e8r6MJ+tYWKkzXr2/SVjNB3VXDsWQD+0gEy3yk49UzEkdMMV+BhfpO2KS5LGJoreWs/pkvsOoiFLuv6BTzJSFkFcoIqwUhhZwUkAgDh3N8kCZpJPGHA50eO7wsHseo8RDmREpkeK2Ve2ks+b/Twc0Us= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DpjZO9/I; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Sq67RQkf; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DpjZO9/I"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Sq67RQkf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789171353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vD3rHJHT6IXoplMI1G9PUB23ltzGVExlvF1tjwSpHoA=; b=DpjZO9/I522C2D05HBYgzPWDjasIVUXkIhNavQ6xx5o0o2fKhc0njr4Y/GNOqCKdaVnSrZ OlYKFWGIjPG32W5NTYoWSozUhFCASdkhROvavd5op011DzrJeLQlFN22Zx9tfPrfbMSbIx iTr9xaAFzNh10PjjA8TOhvGbqhxg3wU= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-uvuqCBB9Pg-m5Sdvl3qlSw-1; Fri, 11 Sep 2026 20:02:32 -0400 X-MC-Unique: uvuqCBB9Pg-m5Sdvl3qlSw-1 X-Mimecast-MFC-AGG-ID: uvuqCBB9Pg-m5Sdvl3qlSw_1789171352 Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-5c405d3e18eso1791295e0c.0 for ; Fri, 11 Sep 2026 17:02:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1789171352; x=1789776152; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=vD3rHJHT6IXoplMI1G9PUB23ltzGVExlvF1tjwSpHoA=; b=Sq67RQkfCFNnFCOi12j+923UfcRdbptyNEGqJVL6gaIMWLovydZh2Za2+7Rvt2hwS7 XnsHJBKKPSGpCmhcAAOKgPt7Ecl4qgClcVRzpv+ETYkOgE37pdfUIGG1+CWrUdxmGoTq EEtaGmkTlcdWzt6LzwYtQ2eIqTmDDnKA1GbKs9qjFXhWIi76RDFWdO3aVdn+6+LYdIW2 TEEH1Za4SAFrozIPvj5CHZZBABj7sHKCV59tAaMedTQyL7YYRTxipiKe5jqwe44j9BVC VwIVtL9qwTYhrAHDXtTLCbr4VdFbG2ZR9KHvETYcz61nmONIBjlsJHZqUn9fXPo5PCqd XaRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789171352; x=1789776152; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vD3rHJHT6IXoplMI1G9PUB23ltzGVExlvF1tjwSpHoA=; b=pQoQ05AMClCKGaN9IXnJAFVIQDN5EndVrFx9eJqPpWuJVFZZo9NhEZSsbiXhdI4L1A TF79+zrpNGM4XmYknqGohf5n9c7aMFEKJdn70O6wR3jO30Rlqbv5DyXEJ7f4+iQolFh0 9R1U4OXmrJCvVrJ9PZ6ypE3N8a9Xf+JQ3cOK9ddpRKogOqGukKRZB0XXuzU4cfUUxT7W bT2zb9A8PebudsXgHscRwPVFuDfxNIbH094Sq2w0QAH4k2reqV3eZSp97ScSvkhCe6gB BpkQ3PcP+aHrF/3y6REdULi4wH3anNRa1Z6z0PsgX3ZKAy7sarXtsw2ex+hnlZF7YS6L lQpw== X-Forwarded-Encrypted: i=1; AKwUvBwRemWEmIBl06a2Eh/D7OF9//vYanlJ79bO4ue9VHYOfQ7QjXJnzlmRKlc6xPDbd4TVWGQPnyol1TYjL8g=@vger.kernel.org X-Gm-Message-State: AFuF++kCgAb3QHv3cmBbc9RIw/540R4E6OJWFH4OiE7CFkZiP5z6K8bT +0H8h42V9lgK1bgf5THLssyPf2eE9dVXxjHcstOCmXZJNVU1E+wIvQjdEoefpdqAyZ8w2JZWknu c6a0cqJqOWppbcc1AdijeV0VkYrl+dYMs2sQL0AA9lDYxOIMNi2mKwOEXb+cbpgqLsw== X-Gm-Gg: AYBFou2Q6e7UcEdfUF64TAN0gBJ5Hx4nOflxesE0n2mTs8giHfchSG0wb9oEbGvB/et FgSBydMS7cEEUF0tvHStTD3LlS0yFRRu+N+S9X5fdONzL80hwUQU6yrBYLK71SX9eLtg/aCe16p TnCpf9vsM6z6YvB1/XB4JXiZ1Fc7wa9VV/QefGuuWJL9wTt9D0hmTmuVbEGUxZRbmcbzrZBaN78 fOFYosTwBAlgQE8hO++0j7kL/Szz+c0hD8siqDzGP6W8Bltvy5ZRSi0V+HHDA8i/eRb5zH89HXT yaTbpKJfdU2c5EQ5TeyNDwHYmho5duNCJ5H49/7B1cTHIupR3FIrKdo1eNvz8ROikTmEh1/o8CB AoPqoKc9w5jGVSVmOibxeqx7Zu0MGyefe/p4= X-Received: by 2002:a05:6102:f88:b0:796:1ed:ba3f with SMTP id ada2fe7eead31-79601edbb2bmr223318137.0.1789171351658; Fri, 11 Sep 2026 17:02:31 -0700 (PDT) X-Received: by 2002:a05:6102:f88:b0:796:1ed:ba3f with SMTP id ada2fe7eead31-79601edbb2bmr223244137.0.1789171351235; Fri, 11 Sep 2026 17:02:31 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9120f4963fcsm32883346d6.33.2026.09.11.17.02.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 17:02:30 -0700 (PDT) Date: Fri, 11 Sep 2026 20:02:28 -0400 From: Brian Masney To: Rosen Penev Cc: linux-clk@vger.kernel.org, Stephen Boyd , Brian Masney , Jerome Brunet , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , "moderated list:ARM/ACTIONS SEMI ARCHITECTURE" , "moderated list:ARM/ACTIONS SEMI ARCHITECTURE" , open list Subject: Re: [PATCH] clk: actions: owl-pll: cast delay to unsigned long for uelay() Message-ID: References: <20260904215013.98283-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260904215013.98283-1-rosenp@gmail.com> User-Agent: Mutt/2.4.0 (2026-06-19) Hi Rosen, The subject has a typo: s/uelay/udelay/ On Fri, Sep 04, 2026 at 02:50:13PM -0700, Rosen Penev wrote: > The 'delay' field in struct owl_pll_hw is u8, but udelay() internally > compares its argument against MAX_UDELAY_MS * 1000 (2000). Since a u8 > can never exceed 255, the compiler warns of a tautological comparison > that is always false: > > drivers/clk/actions/owl-pll.c:189:2: error: result of comparison of > constant 2000 with expression of type 'u8' is always false > > Cast the delay value to unsigned long to widen the type and silence the > warning without changing behavior. Just to clarify: This only shows up with a W=1 build, right? If so, it would be good to clarify that in the commit message. > > Assisted-by: opencode:big-pickle The new guidance is: Assisted-by: LLM Brian