From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B79F157A5A for ; Sat, 12 Sep 2026 00:08:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789171713; cv=none; b=DHkJujd00QUbGgx8J0Pc1xYYh4LwM/sTZ1eeEEdDZb2J/lIcI/XaN5KHHBXmBQyoS75gv2IM+Jz6Pk4fLoO0sJeGdDcofhRKT2EgBy0SgxUAMtxHxxsF4jslBH7zOZ3outvDxRuNPcdp08AIsO72BJKt2jOT58PUPDHCz/XRMsM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789171713; c=relaxed/simple; bh=qg2xXIZS9q8+FQ9NaVnqQx5QGT07BCa7Wy5M4wefSiM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zrj3+TjmqDz+JLRtuM1zamnxK7Jfe9LSuPoVonJv2fezER7B9XNT6k+s05t0LNvdTdwaAmXmCrgP+yyDPJo0KQWxJdYy+d8tFvw1JxbuRaSe0eY+ZeqXMIcMPjsJDjfCud4bkXRqw7OD84CuxDzVJfnUdvsjGHzdyHrGaxrS4vA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=g8QQoOva; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Viu3DDxX; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g8QQoOva"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Viu3DDxX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789171711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r+e6U5jGD86yqBXhoRz8wqGY9P2a9TSeSSbA20YZjfA=; b=g8QQoOvacpz5TJpghxmtMh4vYA9oUyFX8TR1+LEfoEFYiZgM9nXw7jn3ow9X8027zWdS30 9jRwi4hX/yQXCS/sWJsSVO37wjhF8zPiwtsIWrWReMq8d4r2YRfsQSrp7fcg5r0g3ICKt1 I2by67xdUOx38q8aDGGA/aSVqjmgkO8= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-Eq-_lkjNMlu9_qdGQNb3ag-1; Fri, 11 Sep 2026 20:08:30 -0400 X-MC-Unique: Eq-_lkjNMlu9_qdGQNb3ag-1 X-Mimecast-MFC-AGG-ID: Eq-_lkjNMlu9_qdGQNb3ag_1789171709 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-90c8da50f8dso32356236d6.2 for ; Fri, 11 Sep 2026 17:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1789171709; x=1789776509; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=r+e6U5jGD86yqBXhoRz8wqGY9P2a9TSeSSbA20YZjfA=; b=Viu3DDxXEFGseBmlMQxMTMPsPIU5fm7TqvE41+LFBzPYL/OgcGske6+LVxjTy4dAeQ BQrOTnVZ5oV8qLKQkBnlBtlqng1jsY2bi/9ciT/J9Kzx/VsHOQYBvoSLtJ/qS0cvEE+X cvKpWVW8rJMDRURfHcSY/XziCouHIzHN7ot4vpR1Vilh5kGbYBbonZ96ilqnFexC8W3n U67O4Q9XxKQk/rGpJAHesCcFJ9WzDLsldcj39Q7MoLOBp8CpO0emtchNK3Y/T/gTTdsY 9uY/D6a7DebBXx0ofSvCkDEg/dhAvQlV9KI0RZq399YVtCevBgJn1SLVEJNOEXD0yc9l +X9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789171709; x=1789776509; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=r+e6U5jGD86yqBXhoRz8wqGY9P2a9TSeSSbA20YZjfA=; b=Er3A3+4R6fZlH7RMPUExnBwP9+tsZFPf38OOaFKSjDWijrFDapm1kBoIkzXPGm89Q6 LanH+eaDEZx3j5ntGbKrF20VDJA8c2JUchFr3cjB9aleCrY1bWYQYDwleLtWCQNEfSXd 5yMsLJl2gbfXDWjd9vd9+TE/JEFAFHaeBxqSfbYfuArckc6AhHv8VKCeDgNY1tIUyAjB fsL/CofMPFK3dQGWovKFxFKZtUJjzUhREbn+9ATE5m9Il55lJo3kYAAPjsEAlTt4pChC Dif9/+SWQ1PlbAYzoyztITG+SWV41i1WWFuvjulrGbZ8J1NTav5AZUKjNjOqG1kcPsXT HUnQ== X-Forwarded-Encrypted: i=1; AKwUvBwvby6cn3umwZI/STE40PLLK1oaJkt1UWVevUq2jc7Ehs+3jRktfl3nImpBPpm82d4v2teuy4ZqN6idn5U=@vger.kernel.org X-Gm-Message-State: AFuF++nbjaXHVjnRCUKSqjph6qHCgK9NQGNqSPVdOvAL0ujR5Yf7YK65 e0pmU6ANLX/ddV7d5QQvcvp+wE4DU6VOIzt1vVD7xFxOx0GZNYo6CENPRrIkHFS5Ezis8meVYoJ hbIgGSYlQUSI6K+P6rcfziBw4nthM+PvMZ0suocYgGiv1zlhxPaBYoZb5FEjFnqxZPA== X-Gm-Gg: AYBFou2QkVU+FrwjkXSkHK5ladZwWo23x0QYoo6dBF/sdt/dSAPltV+PUGC7eWqdXtB m7QSpN8AcDZRYJ5WYLullog6gATiUnhqGicbCVijG5ftMgUH/4CajhOde82YFEEmUqrPThVDq0t KsKOVp4EFfxNR7WCAXEYhB4qBDktHEmmoW4STH5E+w/JE2W2npMzc42d+IMbSbNxdpQbW3mxJHV Au66buQC2Mqw/weuvtosW35/cf/TkSpH7VQLGqAUbQw8ATCn86A8pVdiYbLALOisgjTg9bxIvF9 AG7O18TMuB0NYEiCJ0vX7dOyMpPM7nQfi/W7e9rcMkuq8a0wwCWbgjKtL2moet70628UnKk999O maV3fUOhfxNj+Jeb0IbFFq+b4KzDEH+lXWS0= X-Received: by 2002:a05:6214:2307:b0:910:722f:b8b with SMTP id 6a1803df08f44-9121da7621emr10925346d6.21.1789171709440; Fri, 11 Sep 2026 17:08:29 -0700 (PDT) X-Received: by 2002:a05:6214:2307:b0:910:722f:b8b with SMTP id 6a1803df08f44-9121da7621emr10924946d6.21.1789171708976; Fri, 11 Sep 2026 17:08:28 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9120f20367dsm32915306d6.6.2026.09.11.17.08.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 17:08:28 -0700 (PDT) Date: Fri, 11 Sep 2026 20:08:26 -0400 From: Brian Masney To: Lucas Tanure Cc: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Jerome Brunet , Kevin Hilman , Martin Blumenstingl , Stephen Boyd , Brian Masney , Chuan Liu , Jian Hu , Ronald Claveau , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] clk: meson: t7: don't mark sys_ampipe_nand as critical Message-ID: References: <20260905153234.133217-1-tanure@linux.com> <20260905153234.133217-5-tanure@linux.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260905153234.133217-5-tanure@linux.com> User-Agent: Mutt/2.4.0 (2026-06-19) Hi Lucas, On Sat, Sep 05, 2026 at 04:32:34PM +0100, Lucas Tanure wrote: > sys_ampipe_nand clocks the pipeline stage inserted in the bus path > between the SD/eMMC controllers and the NIC_MATRIX fabric. It does have > identifiable consumers - the three MMC controllers - so marking it > critical was the wrong tool: the clock should be referenced from the > consumer nodes and claimed by the mmc driver instead. > > Drop the CLK_IS_CRITICAL flag and update the comment accordingly. > sys_am2axi0..2 remain critical as they clock the AXI DMA bus itself and > have no single identifiable consumer. > > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Lucas Tanure > --- > This patch depends on the MMC controllers actually referencing the clock: > the dt-bindings, mmc driver and t7 DTS changes adding the "pipeline" > clock must land before this patch, otherwise the boot hangs and memory > corruption this clock caused are reintroduced. This series should be merged together in one tree? Which tree? I can provide an Acked-by if it should go through the mmc tree. Brian