From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-158.mta0.migadu.com [91.218.175.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D6D2388E55 for ; Sat, 12 Sep 2026 03:09:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789182583; cv=none; b=u+OQgLogm9gnPZvun9Tz1OqqA7cp1PNDRPvtKr+NF9sjGJ8nIPPq4eORfwW6EEzRB7aARaOX2vyBhqFvlGTdn47IzRrUgb9gfXsuMIzgV3kJEh3iem8axAS6oAj+n27+esT+USMOOVKA8JkYcyDvucfZ+jeCu8fyviwa06Rjc78= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789182583; c=relaxed/simple; bh=Iu8FewysYP/Ep//xGcr71N/KuWpAf/0JZgUTITgcNRo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W4uqhpXu8qk8DoXJEzHZ22gCy6arkKb2cPO4xzQyp/9iGgr0UTxvcc5uaDot/TifG5HcwUgCKckIrNVke4bi0YVPlq4yA6tgjmjLB1Y6fCqP6jzL3CWegerVh62XDJjmUfXfYmRHz3JrHuyFD7CkQspiVcnxcD84zXe9FjgLd9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=HKAkhPLS; arc=none smtp.client-ip=91.218.175.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="HKAkhPLS" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=Iu8FewysYP/Ep//xGcr71N/KuWpAf/0JZgUTITgcNRo=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789182578; v=1; x=1789787378; b=HKAkhPLShVk3N0r/3FWzzsFzOrhVyMRzoZO7EdMoAZ01GbxWFrh5oJYzn0VI8bm7f4CGhy5D 6mMkx+e79pEFJEQ033DW8p8qA8kqnHymKyVV8NDlRK0pgnuUo+NKBwKLFsiEMB5zrVjPAPJxYRC 7SwCqa9cIFS+gj1vUyICCQ0k= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 90df69297e1a59c2; Sat, 12 Sep 2026 03:09:28 +0000 X-Mizu-Trace-ID: 90df69297e1a59c2 X-Migadu-Flow: FLOW_OUT Date: Fri, 11 Sep 2026 20:09:27 -0700 From: Shakeel Butt To: Sandeep Dhavale Cc: Greg Kroah-Hartman , Tejun Heo , Christian Brauner , Meta kernel team , driver-core@lists.linux.dev, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] kernfs: Remove kernfs_rwsem from dentry revalidation Message-ID: References: <20260821050507.2161607-1-shakeel.butt@linux.dev> <20260821050507.2161607-5-shakeel.butt@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Sep 11, 2026 at 02:11:53PM -0700, Sandeep Dhavale wrote: > > Hi Sandeep, thanks for the report. Do you have a reproducer? If yes, can you > > reproduce with this series? > > > Hi Shakeel, > No luck with the reproducer yet, and reports have been sporadic. > > > I think first we need a real reproducer before considering anything. I would not > > add a check unless we have proof that it is really needed. > > Ok, I understand. Do you have any opinion on the suspected call chain > which makes dentry->d_inode = NULL; ? I don't see how reclaim can set dentry->d_inode = NULL for a dentry with elevated dentry->d_lockref.count because kernfs_dop_revalidate gets the dentry whose dentry->d_lockref.count is elevated. Reclaim specifically skips such dentries.