mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Chengfeng Lin <lin2530632123@gmail.com>
Cc: "T.J. Mercier" <tjmercier@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jan Kara <jack@suse.cz>,
	driver-core@lists.linux.dev, cgroups@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	regressions@lists.linux.dev
Subject: Re: [REGRESSION] kernfs: empty cgroup rmdir latency after delete-notification changes
Date: Sun, 13 Sep 2026 05:03:06 -1000	[thread overview]
Message-ID: <aqa7KgIJYGgf7INk@slm.duckdns.org> (raw)
In-Reply-To: <CANGjgdn=H50AaA-+O_GA-hkE9UwLANmkjx1zRsKUzxF5za8VfQ@mail.gmail.com>

Hello,

On Sun, Sep 13, 2026 at 10:43:04PM +0800, Chengfeng Lin wrote:
> I found an increase in empty cgroup removal latency across 507d8ce13f5b
> ("kernfs: Don't set_nlink for directories being removed") and eea5d2bb34ba
> ("kernfs: Send IN_DELETE_SELF and IN_IGNORED"). With sched_ext disabled,
> rmdir() went from about 6.5 us to 9.6 us, an increase of 46-47%.
> The result held in two independent runs.

I don't want to make cgroup removal unnecessarily expensive but at the same
time it's not an operation that I consider to be a hot path, so as long as
the operaiton can finish in a reasonable amount of time and single digit us
definitely is, performance of rmdir usually isn't something which is high in
priority. Can you please detail why this matters for you?

Thanks.

-- 
tejun

  reply	other threads:[~2026-09-13 15:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 14:43 Chengfeng Lin
2026-09-13 15:03 ` Tejun Heo [this message]
2026-09-13 15:46   ` Chengfeng Lin
2026-09-13 16:17     ` T.J. Mercier
2026-09-14 18:08       ` Chengfeng Lin
2026-09-15 22:01         ` T.J. Mercier
2026-09-17 10:06           ` Chengfeng Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqa7KgIJYGgf7INk@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=jack@suse.cz \
    --cc=lin2530632123@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=tjmercier@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®