From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0F7F13C9C4 for ; Mon, 14 Sep 2026 00:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789345058; cv=none; b=sGkNVKRhe5GClhoQOPDrW/mtE0QLKMg6omeKzB2eNTf20MqHKc+DalOvEaV43n5WrwPc0jT+8oRCOhoBxdMqrzk+HObLP11DInyC93oDlCgPHcJU5qOI1VJDdhK0FKdyt6HeP+1JD77X4TZV1gTc512fs3kE+1m+pECTD/sZyco= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789345058; c=relaxed/simple; bh=ToUGXbXe0dznPZwkdYYL+ujrWOxxx28Gurz6KZ0/iUM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bG+T5kclHaPrxE9Blj0jQS7yoGyjNmbn8GwqE8cY4hZAIPjL2op9B87TuAHRTZP6bS0n1BwwA5RbkWnvDu/rPuS6YDTWnH/T/Ki9fX69wsEqR/RGbtZPRlP7j9VCMDfQAs91oUB8ehUdV7EPxmxyplhNkibkcOclWsu7pP1Hoho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eRRbRaVT; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eRRbRaVT" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-39dbdfaef3cso1391872a91.1 for ; Sun, 13 Sep 2026 17:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789345057; x=1789949857; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kIKo4cCMWw2kkhyANUDVgYYj+IlcsbApWlNRIap1r8o=; b=eRRbRaVTbvxD5RmQtHLZjJV+FPJsRxAg8SeW85gCKGBtlpdvjR1ToM0TbKBCLF+6OR 390CQHgCAHOha9m6BTRuyGGUmgFza1k/rR6qaUgHuUoNS7RyNsBahcfyL5Jc2C2Ajrxr etKvo3JFHsXTiI4ga/26PG6+cRY1oUQdJqKvxifDcqkncZoiw6mV2lhQbUK3t5fCzWY2 JFXyFXh4Dy92U3B5Mw1RiusGvylSFHuyBkIiEurlPIpsVXeVOnB5eLWGdE28PwacVeXN oDh2puRWmvagTiM1oyANGVj3wR36s/Z4GMrUD3brmisHJ4OpylN4QRWZ+qFpzSjw4cde /w6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789345057; x=1789949857; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kIKo4cCMWw2kkhyANUDVgYYj+IlcsbApWlNRIap1r8o=; b=bS/D/tqU7tRwc7BpQKhTyaXQtH9mevdFcwOcwiTZu8YfFVrbvwMMZKp5XlwXZdF9zm bhVESilh/gBHC2ee3CAk47wKGHNY+pGUg7BBUGohvoccNdl7mfnRPq8g15Bv4sbCfNcT v2Ty9VFPTn0kZKHGoGOiGA0oTJ8cLBv3EaKy8TX6MOQJrp/3sR8tUoQGmZXMDgZQCPos 8agR1UqABHhWZ/YJn0eM9ROFsyxMHp+hmauzWdLiWbB9RswCteFKxQ/X1FzLnLrIsy2q jOpVknoS+43McNOmI+PxH4cEJHZRFfLbVN6Xz7y529+wwVWcLBDTa3LwacnI/D4E6pxa Lo3w== X-Forwarded-Encrypted: i=1; AKwUvByn0Dq+0+WRVTFn1tlEpxgV8lVzJ31HnU+rTFEfaWSp4EgW53TSTVKIXTYHqJn8hFZJWHxLZZHSsBr/IZM=@vger.kernel.org X-Gm-Message-State: AFuF++lKuNfRrAGiDqW3Vfn+mrUGWqJ+nMKrKQrgmCPzYMAKhsNUmSyv 7JHf+lC6ZNmG7VF1fGzTH1N6X5RjUxAAxIL6SNnJrdnN6IwjxIFgWWPm X-Gm-Gg: AYBFou3AaqBkcNC5P2Xpg6ev6N+/Sqgqr3qrYlLwhSQB/EwvNBkMmSJLmFDQOrctk3u AM6lg1tLSF2O1s51Xq9AJbwWWBaHRP5ybjNUo7Rd6PKR8x6NOn8FsuI+25GcWfa9XRQooRqg8aS UuiAKjA5Ct7roW73mSl74vWZbev/XXcPF5XvuJM7duO13MIdvtFgyjByg8AqNqsa7SVQsOhPS9T gOs8wdvpi//PWVftrdD81BdpZwdSRSaP+hWno6ZqRbslYG3PKzfw+dbk3Ey33+OZwLSEDcuuuXE hsAOT7XHPIdyV0w8bvaCrFmKrQl4A84m0wtF9yVuLZ2DqCqP8x2XWQ/IejLEFQ7SG9wGiwAgtD8 LhVfpjHh+H5I5q0PH7R3LrfvflhUm/9d0/vkcGt3R/QsGnv2DNrqDPfbGYAbu7+fWDpqPXkro2X cjfCkB/27DdBhrynoXoQmgUES9PGpfvudBuTBRA3VTgdRnlxnD3DrGo8idZ4ridB4KTi0k9Yoij M17Rk66OETjKVzrX2TtsN+RjVkqQUEXJpfTOp++ X-Received: by 2002:a17:90b:1850:b0:396:40e6:f631 with SMTP id 98e67ed59e1d1-39debf548c6mr731924a91.3.1789345056881; Sun, 13 Sep 2026 17:17:36 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:a739:376c:7eb4:ea2d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33ba7a9bb56sm23934228eec.31.2026.09.13.17.17.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 17:17:35 -0700 (PDT) Date: Sun, 13 Sep 2026 17:17:32 -0700 From: Dmitry Torokhov To: Linmao Li Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: matrix-keymap - reject keycodes above KEY_MAX Message-ID: References: <20260909100739.3107556-1-lilinmao@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260909100739.3107556-1-lilinmao@kylinos.cn> On Wed, Sep 09, 2026 at 06:07:39PM +0800, Linmao Li wrote: > matrix_keypad_map_key() validates the row and column of each entry before > using them to update the keymap. It does not validate the keycode before > using it as a bit number in input_dev->keybit, which only has KEY_CNT bits. > A malformed firmware or platform keymap can therefore write past the > bitmap. > > Reject keycodes above KEY_MAX before updating the keymap or capability > bitmap. > > Fixes: 77a53fd21870 ("Input: matrix-keypad - add function to build device keymap") > Signed-off-by: Linmao Li Applied, thank you. -- Dmitry