From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: sekoohaka.sarisan@gmail.com
Cc: Lee Jones <lee@kernel.org>,
mfd@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mfd: intel-lpss: Fix DebugFS initialization
Date: Mon, 14 Sep 2026 07:29:55 +0300 [thread overview]
Message-ID: <aqd4Q2xYQjChX5tD@ashevche-desk.local> (raw)
In-Reply-To: <20260913-intel-lpss-debugfs-v3-1-1b8e2b1f0992@gmail.com>
On Sun, Sep 13, 2026 at 05:53:53PM +0500, Maria Lisina via B4 Relay wrote:
This is a fair report and patch, but three versions over a night?!
Please, slow down! Even with this kind of patch you have to wait
at least 24h between versions.
> The original code defers DebugFS check with unnecessary warning message
> which also appears when DebugFS is simply disabled.
>
> Therefore it spams dmesg with these messages:
>
> intel-lpss 0000:00:15.0: Failed to create debugfs entries
> intel-lpss 0000:00:15.3: Failed to create debugfs entries
> intel-lpss 0000:00:1e.0: Failed to create debugfs entries
> intel-lpss 0000:00:1e.2: Failed to create debugfs entries
One message is enough as an example.
> This patch adds proper checks to intel_lpss_init() and
> intel_lpss_debugfs_add() functions and removes warning message.
...
> - ret = intel_lpss_debugfs_add(lpss);
> - if (ret)
> - dev_warn(dev, "Failed to create debugfs entries\n");
> + intel_lpss_debugfs_add(lpss);
Obviously this message is added here deliberately. If you are annoyed by it,
we may consider dropping the level.
...
> + /* Ensure intel_lpss_debugfs stays NULL on error,
> + * so intel_lpss_debugfs_add() exits properly.
> + */
/*
* Wrong comment style for multi-line
* comments.
*/
...
TL;DR: moving from warn to info or debug level would be a good compromise.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-14 4:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 12:53 Maria Lisina via B4 Relay
2026-09-14 4:29 ` Andy Shevchenko [this message]
2026-09-15 11:02 ` Lee Jones
2026-09-15 13:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqd4Q2xYQjChX5tD@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=sekoohaka.sarisan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®