mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@arm.com>, Leo Yan <leo.yan@arm.com>,
	John Garry <john.g.garry@oracle.com>,
	Will Deacon <will@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Suyash Mahar <smahar@meta.com>, Leo Yan <leo.yan@linux.dev>,
	linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH 00/14] perf cs-etm: Per-thread mode fixes and snapshot wrap support
Date: Sun, 13 Sep 2026 22:20:31 -0300	[thread overview]
Message-ID: <aqdL33fw9AoxTrPq@x2> (raw)
In-Reply-To: <20260811-james-cs-unformatted-per-thread-fix-v1-0-90565318f5f8@linaro.org>

On Tue, Aug 11, 2026 at 04:30:03PM +0100, James Clark wrote:
> Fix a few issues with per-thread mode:
>   - With TRBE, thread migrations hit a queue without a decoder assert
>   - On nVHE, everything looks like guest trace instead of host
>   - Tracing multiple threads didn't really work

This series applies cleanly to perf-tools-next but has no Reviewed-by
nor was processed by Sashiko.

Can somebody from the ARM camp take a look at it, please?

Thanks,

- Arnaldo
 
> After adding a tests for those, it turns out there were some snapshot
> bugs not picked up by the other snapshot tests. That showed that the
> different snapshot searches for Intel BTS and Arm SPE were inconsistent
> and I think all tracers can benefit from using the same pointer fixup
> logic, so that gets refactored into the common auxtrace.c. Then SPE can
> just share the Intel BTS search as it was obviously copied from it
> originally. IntelPT keeps the more advanced duplicate data search, but
> in the future that could probably be made the common one and all tracers
> would benefit from using it (except maybe BTS if it always has a very
> small buffer, but I doubt the overhead of the duplicate search would be
> an issue). For now this is more of a refactor rather than behavioral
> change so don't do that yet.
> 
> Signed-off-by: James Clark <james.clark@linaro.org>
> ---
> James Clark (14):
>       perf cs-etm: Fix nVHE per-thread decoding
>       perf cs-etm: Warn for invalid timestamp option
>       perf cs-etm: Turn on context packet timestamps in per-thread mode
>       perf cs-etm: Use per-CPU queues for per-thread mode
>       perf cs-etm: Increase default timestamp generation period
>       perf auxtrace: Turn Intel BTS snapshot search into a generic one
>       perf arm-spe: Use generic snapshot search
>       perf auxtrace: intel-pt: Use new snapshot_has_wrapped callback
>       perf cs-etm: Queue partial AUX records
>       perf cs-etm: Don't print missing buffers in snapshot mode
>       perf auxtrace: cs-etm: Capture wrapped snapshots
>       perf test: Allow infinite named_thread loops
>       perf test: Add test for per-thread mode
>       perf cs-etm: Test multiple per-thread threads
> 
>  Documentation/userspace-api/perf_ring_buffer.rst   |   6 +-
>  tools/perf/Documentation/perf-test.txt             |   2 +-
>  tools/perf/arch/arm/util/cs-etm.c                  |  30 ++++-
>  tools/perf/arch/arm64/util/arm-spe.c               | 147 +--------------------
>  tools/perf/arch/x86/util/intel-bts.c               | 115 +---------------
>  tools/perf/arch/x86/util/intel-pt.c                |  58 +++-----
>  .../perf/tests/shell/coresight/per-thread-multi.sh |  78 +++++++++++
>  tools/perf/tests/shell/coresight/per-thread.sh     |  48 +++++++
>  .../perf/tests/shell/coresight/raw_dump_stress.sh  |   5 -
>  tools/perf/tests/workloads/named_threads.c         |   7 +-
>  tools/perf/util/auxtrace.c                         | 136 +++++++++++++++++--
>  tools/perf/util/auxtrace.h                         |  20 ++-
>  tools/perf/util/cs-etm.c                           |  98 ++++++++++----
>  13 files changed, 382 insertions(+), 368 deletions(-)
> ---
> base-commit: bf10e6ee2ac3034c9068e03eed418fd16961984e
> change-id: 20260605-james-cs-unformatted-per-thread-fix-50e723aa7f0e
> 
> Best regards,
> --  
> James Clark <james.clark@linaro.org>

  parent reply	other threads:[~2026-09-14  1:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 15:30 James Clark
2026-08-11 15:30 ` [PATCH 01/14] perf cs-etm: Fix nVHE per-thread decoding James Clark
2026-08-11 15:30 ` [PATCH 02/14] perf cs-etm: Warn for invalid timestamp option James Clark
2026-08-11 15:30 ` [PATCH 03/14] perf cs-etm: Turn on context packet timestamps in per-thread mode James Clark
2026-08-11 15:30 ` [PATCH 04/14] perf cs-etm: Use per-CPU queues for " James Clark
2026-08-11 15:30 ` [PATCH 05/14] perf cs-etm: Increase default timestamp generation period James Clark
2026-08-11 15:30 ` [PATCH 06/14] perf auxtrace: Turn Intel BTS snapshot search into a generic one James Clark
2026-08-11 15:30 ` [PATCH 07/14] perf arm-spe: Use generic snapshot search James Clark
2026-08-11 15:30 ` [PATCH 08/14] perf auxtrace: intel-pt: Use new snapshot_has_wrapped callback James Clark
2026-08-11 15:30 ` [PATCH 09/14] perf cs-etm: Queue partial AUX records James Clark
2026-08-11 15:30 ` [PATCH 10/14] perf cs-etm: Don't print missing buffers in snapshot mode James Clark
2026-08-11 15:30 ` [PATCH 11/14] perf auxtrace: cs-etm: Capture wrapped snapshots James Clark
2026-08-11 15:30 ` [PATCH 12/14] perf test: Allow infinite named_thread loops James Clark
2026-08-11 15:30 ` [PATCH 13/14] perf test: Add test for per-thread mode James Clark
2026-08-11 15:30 ` [PATCH 14/14] perf cs-etm: Test multiple per-thread threads James Clark
2026-09-14  1:20 ` Arnaldo Carvalho de Melo [this message]
2026-09-14  8:13   ` [PATCH 00/14] perf cs-etm: Per-thread mode fixes and snapshot wrap support Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqdL33fw9AoxTrPq@x2 \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=coresight@lists.linaro.org \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=leo.yan@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=smahar@meta.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®