From: Dan Carpenter <error27@gmail.com>
To: Gabriel Changamire <gaberashawn@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: sm750fb: remove unused definitions from ddk750_reg.h
Date: Mon, 14 Sep 2026 11:54:03 +0300 [thread overview]
Message-ID: <aqe2K0nVppBFSidV@stanley.mountain> (raw)
In-Reply-To: <20260913040140.4517-2-gaberashawn@gmail.com>
On Sun, Sep 13, 2026 at 04:01:40AM +0000, Gabriel Changamire wrote:
> The sm750fb TODO asks for unused code to be removed. Of the 1203
> register and field definitions in ddk750_reg.h, 1046 are referenced
> neither by the rest of the driver nor, transitively, by any definition
> that is referenced.
>
> Remove them, together with section comments that are left with no
> content beneath them. The include guard and all VALIDATION_CHIP
> conditional blocks are preserved.
>
> Build-tested: all driver objects are byte-identical before and after
> the change. No functional change.
>
> Signed-off-by: Gabriel Changamire <gaberashawn@gmail.com>
> ---
These macros are just documentation and they don't hurt readability.
They probably improve readability.
regards,
dan carpenter
next prev parent reply other threads:[~2026-09-14 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 4:01 [PATCH 1/2] staging: sm750fb: clean up sm750_hw_imageblit() kernel-doc comment Gabriel Changamire
2026-09-13 4:01 ` [PATCH 2/2] staging: sm750fb: remove unused definitions from ddk750_reg.h Gabriel Changamire
2026-09-14 8:54 ` Dan Carpenter [this message]
2026-09-14 8:54 ` [PATCH 1/2] staging: sm750fb: clean up sm750_hw_imageblit() kernel-doc comment Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqe2K0nVppBFSidV@stanley.mountain \
--to=error27@gmail.com \
--cc=gaberashawn@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®