From: Stefano Garzarella <sgarzare@redhat.com>
To: Gokul K <gokul02k@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@kernel.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
x86@kernel.org
Subject: Re: [PATCH] x86/sev: Do not fail SNP platform init if the vTPM cannot be registered
Date: Mon, 14 Sep 2026 09:48:20 +0200 [thread overview]
Message-ID: <aqekSpzm14h6fEJr@sgarzare-redhat> (raw)
In-Reply-To: <20260912182454.2292590@gmail.com>
On Sat, Sep 12, 2026 at 11:54:54PM +0530, Gokul K wrote:
>> I'm opposed convert to an error message, but honestly I don't understand
>> which problem we are fixing.
Sorry, of course I meant "I'm NOT opposed to"!
>
>Only an inconsistency: no vTPM returns 0, a failed registration returns
>-ENODEV, both leave sev-guest registered, and nothing reads the return
>value. The failure itself should not happen in practice and I am not
>arguing otherwise.
>
>Happy to drop this if you would rather keep the -ENODEV.
Up to the maintainers. I'm fine with both, but TBH if SVSM tells us it
has a TPM device and we can't register the device in the system,
something is seriously wrong, so returning an error seems fine to me,
since we were not able to properly configure the SNP platform.
Thanks,
Stefano
prev parent reply other threads:[~2026-09-14 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 5:34 Gokul K
2026-09-10 8:24 ` Stefano Garzarella
2026-09-12 18:24 ` Gokul K
2026-09-14 7:48 ` Stefano Garzarella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqekSpzm14h6fEJr@sgarzare-redhat \
--to=sgarzare@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gokul02k@gmail.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®