Re: [PATCH 6/8] KVM: selftests: Enable pre_fault_memory_test for arm64

["Lorenzo Stoakes (ARM)" <ljs@kernel.org>]

On Thu, Sep 10, 2026 at 07:52:35PM +0100, Fuad Tabba wrote:
> On Tue, 25 Aug 2026 at 17:01, Lorenzo Stoakes (ARM) <ljs@kernel.org> wrote:
> >
> > From: Jack Thomson <jackabt@amazon.com>
> >
> > Enable the pre_fault_memory_test to run on arm64 by making it work with
> > different guest page sizes and testing multiple guest configurations.
> >
> > Update the test_assert to compare against the UCALL_EXIT_REASON, for
> > portability, as arm64 exits with KVM_EXIT_MMIO while x86 uses
> > KVM_EXIT_IO.
>
> The message says this updates the test_assert for portability, but the
> parent has no exit-reason assert and no struct kvm_run; this patch
> adds both, so there was no hardcoded KVM_EXIT_IO to make portable.

Ack will fix up for v2 thanks!

>
> ...
>
> >  int main(int argc, char *argv[])
> >  {
> ...
> > +
> >         TEST_REQUIRE(kvm_check_cap(KVM_CAP_PRE_FAULT_MEMORY));
> >
> >         test_pre_fault_memory(0, false);
>
> Would it be worth adding an arm64 case for gmem_abort()'s pre-fault path?

I think doing this would be quite a bit of work, I think perhaps one for a
follow-up?

>
> Cheers,
> /fuad
>
> >
> > --
> > 2.55.0
> >

--
Cheers, Lorenzo