From: Uladzislau Rezki <urezki@gmail.com>
To: Ye Liu <ye.liu@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Uladzislau Rezki <urezki@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Ye Liu <liuye@kylinos.cn>
Subject: Re: [PATCH 3/3] mm/vmalloc: extract show_busy_info from vmalloc_info_show
Date: Mon, 14 Sep 2026 19:10:37 +0200 [thread overview]
Message-ID: <aqgqjRJ8qpYmx04v@milan> (raw)
In-Reply-To: <20260914-vmalloc_study-v1-3-526f68559706@linux.dev>
On Mon, Sep 14, 2026 at 11:34:02AM +0800, Ye Liu wrote:
> From: Ye Liu <liuye@kylinos.cn>
>
> Extract the busy vmap area iteration into show_busy_info, mirroring
> the existing show_purge_info pattern.
>
> Signed-off-by: Ye Liu <liuye@kylinos.cn>
> ---
> mm/vmalloc.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 797933ba9451..7638845377f5 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -5345,12 +5345,12 @@ static void show_purge_info(struct seq_file *m)
> }
> }
>
> -static int vmalloc_info_show(struct seq_file *m, void *p)
> +static void show_busy_info(struct seq_file *m)
> {
> struct vmap_node *vn;
> struct vmap_area *va;
> struct vm_struct *v;
> - unsigned int *counters;
> + unsigned int *counters = NULL;
>
Is setting counters setting to NULL odd here?
Other than that, LGTM:
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
--
Uladzislau Rezki
next prev parent reply other threads:[~2026-09-14 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 3:33 [PATCH 0/3] mm/vmalloc: minor cleanups Ye Liu
2026-09-14 3:34 ` [PATCH 1/3] mm/vmalloc: group xa_init with vbq field initializations Ye Liu
2026-09-14 16:57 ` Uladzislau Rezki
2026-09-15 3:52 ` Dev Jain
2026-09-14 3:34 ` [PATCH 2/3] mm/vmalloc: extract vmap_insert_free_area helper Ye Liu
2026-09-14 17:02 ` Uladzislau Rezki
2026-09-15 2:25 ` Ye Liu
2026-09-15 3:48 ` Dev Jain
2026-09-14 3:34 ` [PATCH 3/3] mm/vmalloc: extract show_busy_info from vmalloc_info_show Ye Liu
2026-09-14 17:10 ` Uladzislau Rezki [this message]
2026-09-15 2:26 ` Ye Liu
2026-09-15 4:38 ` Andrew Morton
2026-09-15 4:23 ` Dev Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqgqjRJ8qpYmx04v@milan \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuye@kylinos.cn \
--cc=ye.liu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®