From: Isaac Manjarres <isaacmanjarres@google.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: 高翔 <gaoxiang17@xiaomi.com>,
"David Hildenbrand (Arm)" <david@kernel.org>,
"Xiang Gao" <gxxa03070307@gmail.com>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrew Morton" <akpm@linux-foundation.org>,
印闯 <yinchuang1@xiaomi.com>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Lorenzo Stoakes (Arm)" <ljs@kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>
Subject: Re: [External Mail]Re: [RFC] bpf: account ring buffer backing pages separately from Lost RAM
Date: Mon, 14 Sep 2026 15:32:12 -0700 [thread overview]
Message-ID: <aqh17GTlWiDVJ-N1@google.com> (raw)
In-Reply-To: <aqhZEuQTu394hYB6@google.com>
On Mon, Sep 14, 2026 at 01:29:06PM -0700, Isaac Manjarres wrote:
> On Fri, Sep 11, 2026 at 05:04:55PM -0700, Andrii Nakryiko wrote:
> > On Fri, Sep 11, 2026 at 4:24 PM Isaac Manjarres
> > <isaacmanjarres@google.com> wrote:
> > >
> > > On Wed, Aug 19, 2026 at 10:24:28AM -0700, Andrii Nakryiko wrote:
> > > > On Tue, Aug 18, 2026 at 6:46 AM 高翔 <gaoxiang17@xiaomi.com> wrote:
> > > > >
> > > > > Thanks for the pointer. Understood — no new NR_* counter or
> > > > > /proc/meminfo entry.
> > > > >
> > > > >
> > > > > The remaining question is on the consumer side: Android's Lost RAM
> > > > > accounting would need to enumerate all live BPF ringbuf maps
> > > > > (BPF_MAP_GET_NEXT_ID) and read each map's fdinfo memlock to sum them.
> > > > >
> > > >
> > > > For BPF ringbufs specifically, you should be fine just iterating all
> > > > map with BPF_MAP_GET_NEXT_ID, getting its FD with
> > > > BPF_BTF_GET_FD_BY_ID, and then passing that fd to
> > > > BPF_OBJ_GET_INFO_BY_FD to get map's size.
> > > >
> > > Hi Andrii,
> > >
> > > Thanks for the suggestion on this! I did want to express a couple of
> > > concerns with this:
> > >
> > > Scalability
> > >
> > > I counted the number of maps on one of our devices, and there are 112
> > > maps, meaning that there will be between 224-336 syscalls with this
> > > approach. eBPF is becoming more popular, so I'm concerned about how well
> > > this will scale, if we have to invoke 2-3 syscalls per map.
> > >
> > > I had a test program that implemented your suggestion, and it took about
> > > 2 ms to identify 39/112 ringbufs. As the number of maps in the system
> > > grows, I'm concerned that the latency associated with computing the
> > > memory usage from ringbufs will become even more expensive. This is
> > > something we had an issue with before on Android, where we had to
> > > iterate through various sysfs files to gather wakeupsource metrics [1].
> > >
> > > To improve on this, I was wondering if we could expose the ringbuf
> > > memory usage and potentially other bpf stats through bpffs
> > > (/sys/fs/bpf/stats)? This counter could be a lightweight counter that is
> > > incremented/decremented on ringbuf allocation/freeing so that when it is
> > > read, there aren't any expensive computations.
> > >
> > > For this specific metric, we could just use a counter to track how much
> > > memory is being used by ringbufs and have userspace read that. That also
> > > brings me to my next point.
> > >
> >
> > I just don't see a good enough reason to single out ringbuf maps
> > specifically. other map types also use memory, why would they be
> > excluded?
>
> I was looking at ringbuf maps specifically because they allocate memory
> for the ringbuf via alloc_pages() and aren't attributed to any counter
> that is exposed to userspace. The other maps use either the slab
> allocator or vmalloc() to allocate memory, and those entries are visible
> via /proc/meminfo.
>
> > If you are worried about too many syscalls, look into map iterator
> > program types (grep for SEC("iter/bpf_map") in selftests). That will
> > be super fast and way more generic than what you propose. You can ping
> > such program in bpffs and that will be you custom /sys/fs/bpf/stats
> > implementation that you have full control and customizability of
> >
>
> Thanks for the suggestion; I'll look into this and let you know if I
> have any questions!
>
I looked into this, and this works in reducing the overhead from number
of syscalls, but the other part about correctness isn't handled by this.
For ringbuf maps we would have access to max_entries, but that just gives
us the amount of memory consumed by the data portion of the ringbuf, but
it doesn't include the 3 metadata (kernel structures, consumer idx page,
and producer idx page). I don't see how to derive this value--rather
than hardcoding it.
I did see that fdinfo for the maps does give the total memory usage
via bpf_map_memory_usage(). However, that value includes structures that
are allocated through the slab allocator and vmalloc, so using that
value would double count the memory usage in the system. Userspace
doesn't have the information required to break that value up to extract
just the part that is allocated through alloc_pages() directly.
I think it's worthwhile accounting this data correctly, as on our setup
there are 39 ringbufs. This can lead to 468 kB -- 1872 kB of unaccounted
memory depending on the page size.
--Isaac
prev parent reply other threads:[~2026-09-14 22:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 9:18 Xiang Gao
2026-08-17 18:10 ` David Hildenbrand (Arm)
2026-08-17 18:22 ` Andrii Nakryiko
[not found] ` <8d2e20842c24460296e4c83e6dc0dde3@xiaomi.com>
2026-08-19 17:24 ` [External Mail]Re: " Andrii Nakryiko
2026-09-11 23:24 ` Isaac Manjarres
2026-09-12 0:04 ` Andrii Nakryiko
2026-09-14 20:29 ` Isaac Manjarres
2026-09-14 22:32 ` Isaac Manjarres [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqh17GTlWiDVJ-N1@google.com \
--to=isaacmanjarres@google.com \
--cc=akpm@linux-foundation.org \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=david@kernel.org \
--cc=gaoxiang17@xiaomi.com \
--cc=gxxa03070307@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=rostedt@goodmis.org \
--cc=yinchuang1@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®