Hello, On Tue, Sep 15, 2026 at 12:05:42AM +0100, Alexey Klimov wrote: > - added mod_devicetable.h as Tudor suggested, added trailer in the first > commit; Argh, the reasoning in that suggestion was: you need to include linux/mod_devicetable.h for kernel_ulong_t. (https://lore.kernel.org/all/1c41ecc9-d951-45df-b933-1934e1381663@linaro.org/). This is wrong: $ git grep kernel_ulong_t v7.3-rc1:include/linux/mod_devicetable.h || echo void void Please drop the inclusion of again, the only effect of including is that you introduce a bunch of unneeded build dependencies and I'm fighting to get rid of that file. Also note that the driver is already using struct platform_device_id which obviously has a member with type kernel_ulong_t. If you'd need an additional header for kernel_ulong_t, the driver wouldn't have compiled already before. already pulls in the definition of struct platform_device_id and thus also kernel_ulong_t. Please rely on that or if you want to go full iwyu include Best regards Uwe