mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kiryl Shutsemau <kas@kernel.org>
To: Lance Yang <lance.yang@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	 "David Hildenbrand (Arm)" <david@kernel.org>,
	ziy@nvidia.com, baolin.wang@linux.alibaba.com,
	 liam@infradead.org, nico.pache@linux.dev, ryan.roberts@arm.com,
	dev.jain@arm.com,  baohua@kernel.org, usama.arif@linux.dev,
	ljs@kernel.org, surenb@google.com,  linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/1] mm/huge_memory: fix pgtable withdrawal for huge zero PMDs
Date: Tue, 15 Sep 2026 14:52:11 +0100	[thread overview]
Message-ID: <aqlMvfIhr8nD9RHB@thinkstation> (raw)
In-Reply-To: <30bcc70c-be07-4237-9bb1-554aa5b5c5c2@linux.dev>

On Tue, Sep 15, 2026 at 09:43:15PM +0800, Lance Yang wrote:
> 
> 
> On 2026/9/15 02:19, Andrew Morton wrote:
> > On Mon, 14 Sep 2026 16:29:00 +0200 "David Hildenbrand (Arm)" <david@kernel.org> wrote:
> > 
> > > On 9/14/26 12:59, Kiryl Shutsemau wrote:
> > > > On Sun, Sep 13, 2026 at 03:23:12PM +0800, Lance Yang wrote:
> > > > > 
> > > > > On Sat, Sep 12, 2026 at 11:46:35PM -0700, Andrew Morton wrote:
> > > > > > 
> > > > > > 
> > > > > > That's the sort of thing we'd prefer to avoid.
> > > > > > 
> > > > > > 
> > > > > > How real is this?  Is there a reported-by:?  Do you have a reproducer?
> > > > > 
> > > > > Yes, I reproduced it on x86 with a small test module. It sets
> > > > > VM_MIXEDMAP | VM_HUGEPAGE and calls vmf_insert_pfn_pmd() with
> > > > > huge_zero_pfn, without touching the page tables directly. A full-PMD
> > > > > munmap() crashes before the split series[1] as well.
> > > > 
> > > > Ah. So there's no real bug upstream, right?
> > > 
> > > Matches my understanding.
> > 
> > Thanks.  I'll remove cc:stable, move this into mm-unstable as a
> > next-merge-window thing.
> 
> Sounds good to me, thanks, Andrew!
> 
> Kiryl, David, would you prefer the validation for raw-PFN mappings
> of the huge zero page as a separate follow-up, or should that
> validation replace this patch? wdyt

I think this patch can be useful for graceful recovery if we somehow ended up
with a zero page in a mapping where we shouldn't have one.

A separate patch with validation would be great.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov

  reply	other threads:[~2026-09-15 13:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13  5:19 Lance Yang
2026-09-13  6:46 ` Andrew Morton
2026-09-13  7:23   ` Lance Yang
2026-09-14 10:59     ` Kiryl Shutsemau
2026-09-14 14:29       ` David Hildenbrand (Arm)
2026-09-14 18:19         ` Andrew Morton
2026-09-15 13:43           ` Lance Yang
2026-09-15 13:52             ` Kiryl Shutsemau [this message]
2026-09-15 15:03               ` David Hildenbrand (Arm)
2026-09-15 15:13 ` David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqlMvfIhr8nD9RHB@thinkstation \
    --to=kas@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=nico.pache@linux.dev \
    --cc=ryan.roberts@arm.com \
    --cc=stable@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=usama.arif@linux.dev \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®