From: Mark Brown <broonie@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>,
Wireless <linux-wireless@vger.kernel.org>
Cc: Johannes Berg <johannes.berg@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: manual merge of the wireless-next tree with the wireless tree
Date: Tue, 15 Sep 2026 15:20:22 +0100 [thread overview]
Message-ID: <aqlUJnjxj1lroNev@sirena.org.uk> (raw)
[-- Attachment #1: Type: text/plain, Size: 2929 bytes --]
Hi all,
Today's linux-next merge of the wireless-next tree got a conflict in:
drivers/net/wireless/virtual/mac80211_hwsim_main.c
between commit:
87840d4a3a21b ("wifi: mac80211_hwsim: don't hand frames to mac80211 while stopping")
from the wireless tree and commit:
41416127e37e4 ("wifi: mac80211_hwsim: overwrite report SKB")
from the wireless-next tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
diff --cc drivers/net/wireless/virtual/mac80211_hwsim_main.c
index b9446577ff499,9f895ad718e9b..0000000000000
--- a/drivers/net/wireless/virtual/mac80211_hwsim_main.c
+++ b/drivers/net/wireless/virtual/mac80211_hwsim_main.c
@@@ -6540,13 -6543,51 +6548,58 @@@ static int hwsim_cloned_frame_received_
goto out;
}
+ /*
+ * Serialise against mac80211_hwsim_stop() - mac80211 doesn't allow
+ * frames reported while the HW is down, hence the ->started check
+ * must be under mutex.
+ */
+ mutex_lock(&data2->mutex);
+
+ /* look for the skb matching the cookie passed back from user */
+ if (info->attrs[HWSIM_ATTR_COOKIE] &&
+ info->attrs[HWSIM_ATTR_ADDR_TRANSMITTER]) {
+ u64 cookie = nla_get_u64(info->attrs[HWSIM_ATTR_COOKIE]);
+ struct sk_buff *orig_skb, *found = NULL;
+ struct mac80211_hwsim_data *txdata;
+ struct ieee80211_tx_info *txi;
+ const u8 *transmitter;
+ unsigned long flags;
+
+ transmitter = nla_data(info->attrs[HWSIM_ATTR_ADDR_TRANSMITTER]);
+ txdata = get_hwsim_data_ref_from_addr(transmitter);
+ if (!txdata || txdata->netgroup != data2->netgroup)
- goto out;
++ goto out_unlock;
+
+ spin_lock_irqsave(&txdata->pending.lock, flags);
+ skb_queue_walk(&txdata->pending, orig_skb) {
+ uintptr_t skb_cookie;
+
+ txi = IEEE80211_SKB_CB(orig_skb);
+ skb_cookie = (uintptr_t)txi->rate_driver_data[0];
+
+ if (skb_cookie == cookie) {
+ found = orig_skb;
+ break;
+ }
+ }
+
+ /* that's weird */
+ if (!found) {
+ spin_unlock_irqrestore(&txdata->pending.lock, flags);
- goto out;
++ goto out_unlock;
+ }
+
+ if (frame_data_len > found->len &&
+ pskb_expand_head(found, 0, frame_data_len - found->len,
+ GFP_ATOMIC)) {
+ spin_unlock_irqrestore(&txdata->pending.lock, flags);
- goto out;
++ goto out_unlock;
+ }
+ skb_trim(found, 0);
+ skb_put_data(found, frame_data, frame_data_len);
+ spin_unlock_irqrestore(&txdata->pending.lock, flags);
+ }
+
/* check if radio is configured properly */
if ((data2->idle && !data2->tmp_chan) || !data2->started)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2026-09-15 14:20 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 14:20 Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-09-09 12:12 Mark Brown
2025-07-16 3:52 Stephen Rothwell
2025-07-16 8:59 ` Johannes Berg
2025-07-16 11:54 ` Stephen Rothwell
2025-07-16 17:18 ` Jeff Johnson
2024-10-28 1:36 Stephen Rothwell
2024-10-28 6:51 ` Johannes Berg
2024-10-31 2:20 ` Stephen Rothwell
2024-10-24 0:55 Stephen Rothwell
2024-10-24 6:58 ` Johannes Berg
2024-10-31 2:24 ` Stephen Rothwell
2024-06-03 1:01 Stephen Rothwell
2024-06-03 10:01 ` Kalle Valo
2024-06-06 10:09 ` Kalle Valo
2024-06-07 9:44 ` Alexis Lothoré
2024-06-07 10:29 ` Kalle Valo
2024-05-31 2:44 Stephen Rothwell
2024-04-22 0:56 Stephen Rothwell
2024-03-25 23:09 Stephen Rothwell
2024-03-26 7:58 ` Johannes Berg
2024-02-08 23:56 Stephen Rothwell
2024-02-09 7:03 ` Johannes Berg
2023-09-26 2:20 Stephen Rothwell
2023-09-26 2:02 Stephen Rothwell
2023-09-26 2:41 ` Stephen Rothwell
2023-09-26 6:21 ` Johannes Berg
2023-09-12 2:46 Stephen Rothwell
2023-03-30 23:49 Stephen Rothwell
2023-03-31 9:17 ` Johannes Berg
2023-04-03 2:23 ` Stephen Rothwell
2023-04-03 8:43 ` Kalle Valo
2014-11-25 3:36 Stephen Rothwell
2013-12-03 0:20 Stephen Rothwell
2013-12-03 15:52 ` John W. Linville
2013-12-03 16:09 ` Johannes Berg
2013-12-03 18:12 ` Bob Copeland
2013-12-04 1:21 ` Yeoh Chun-Yeow
2013-08-19 2:41 Stephen Rothwell
2013-08-12 1:53 Stephen Rothwell
2013-08-12 15:15 ` John W. Linville
2013-08-12 15:34 ` Berg, Johannes
2013-06-07 2:56 Stephen Rothwell
2013-06-07 6:21 ` Sujith Manoharan
2013-03-26 1:18 Stephen Rothwell
2013-03-12 1:00 Stephen Rothwell
2012-11-15 2:17 Stephen Rothwell
2012-11-15 8:06 ` Arend van Spriel
2012-10-22 0:46 Stephen Rothwell
2012-10-22 0:13 Stephen Rothwell
2011-11-14 0:53 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqlUJnjxj1lroNev@sirena.org.uk \
--to=broonie@kernel.org \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®