From: Karl Mehltretter <kmehltretter@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Haren Myneni <haren@us.ibm.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Dan Streetman <ddstreet@ieee.org>,
Andrew Morton <akpm@linux-foundation.org>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <david@davidgow.net>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] lib/842: add KUnit tests for the decompressor
Date: Tue, 15 Sep 2026 20:28:47 +0200 [thread overview]
Message-ID: <aqmN7Wt4f-DXGEhn@gmail.com> (raw)
In-Reply-To: <CAMuHMdVcZ5cV4-HrjLYfFKh6UshiVxq5eXCNyp0Z1k_SMAvF5g@mail.gmail.com>
On Tue, Sep 15, 2026 at 02:57:55PM +0100, Geert Uytterhoeven wrote:
> > +config 842_DECOMPRESS_KUNIT_TEST
> > + tristate "KUnit tests for the 842 decompressor" if !KUNIT_ALL_TESTS
> > + depends on KUNIT
> > + select 842_DECOMPRESS
>
> Enabling a (modular) test should not silently enable additional kernel
> functionality, as that may increase the attack vector for a product.
>
Hi Geert,
Wow, good catch, thank you! I'll prepare a follow-up to fix it.
I also found a few other KUnit tests using the same select pattern,
so I'll look into fixing those as well.
Karl
next prev parent reply other threads:[~2026-09-15 18:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-29 9:18 [PATCH v1 0/3] lib/842: reject malformed streams before invalid memory accesses Karl Mehltretter
2026-08-29 9:18 ` [PATCH v1 1/3] lib/842: reject output overflows from index and short data Karl Mehltretter
2026-08-29 9:18 ` [PATCH v1 2/3] lib/842: require a complete history block for repeat templates Karl Mehltretter
2026-08-29 9:18 ` [PATCH v1 3/3] lib/842: add KUnit tests for the decompressor Karl Mehltretter
2026-09-15 12:57 ` Geert Uytterhoeven
2026-09-15 18:28 ` Karl Mehltretter [this message]
2026-09-11 5:30 ` [PATCH v1 0/3] lib/842: reject malformed streams before invalid memory accesses Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqmN7Wt4f-DXGEhn@gmail.com \
--to=kmehltretter@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=brendan.higgins@linux.dev \
--cc=david@davidgow.net \
--cc=ddstreet@ieee.org \
--cc=geert@linux-m68k.org \
--cc=haren@us.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=kunit-dev@googlegroups.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®