From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-240.mta0.migadu.com [91.218.175.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F4213AEF28 for ; Wed, 16 Sep 2026 02:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.240 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789524904; cv=none; b=msS+v67t1q3p8tu/QaFpQtma8K+PDqHIxGu2eR0+EUbq5SGrHi8GGloMFePIr4Zp5c9CNcPlIKqiy8UCeAsJCt6qMFYirblwrjBch3DIV9xGjj3p+1CdbCGdarwuLYjmgXyxYWGIFpHILznrhtK9n1gfrFCTXBYl1ulxHb4nVVg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789524904; c=relaxed/simple; bh=lqLsdeTEg6cA2AaSBrBEJdlEzfNC4PV/xJxx+hp/HkE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BxP2pV5jHD8039+xpwtVmLSTW9quTxyAxBZTUdiVbqo5GTUJHZZgMHebenHMIOqdV1qbVWieGkUb84bYw+p/b5qsksFHffwmwXXlBsNr0pQgbZuSUYjLIV30wezNPJTN7UeUvzthhy6OYNrggTSZh1xVdSjzMqZm0ZnnDdLyKwc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=K8deB8et; arc=none smtp.client-ip=91.218.175.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="K8deB8et" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=lqLsdeTEg6cA2AaSBrBEJdlEzfNC4PV/xJxx+hp/HkE=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789524889; v=1; x=1790129689; b=K8deB8etutTS0bx6JOtfjx9Pv09f0fg1Sww/JfiyNxtsz09/PpnkKFhrX/MltuqWx4+JUx7M rAcfURnxR/0lDp9SKWZf3reXV0BmwCAgVg/vwLpBEbrwcQU5BwHgl2ofDqpIg3csq+3J34tO3U6 SamAD/l8cx98qmTJY72xMDlo= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta10.migadu.com with ESMTPS id 7a9ac813747d9e7d; Wed, 16 Sep 2026 02:14:39 +0000 X-Mizu-Trace-ID: 7a9ac813747d9e7d X-Migadu-Flow: FLOW_OUT Date: Wed, 16 Sep 2026 10:14:31 +0800 From: Baoquan He To: Ridong Chen Cc: Steven Rostedt , Masami Hiramatsu , Andrew Morton , Johannes Weiner , Mathieu Desnoyers , Kairui Song , Qi Zheng , Shakeel Butt , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Baolin Wang , David Hildenbrand , Michal Hocko , Lorenzo Stoakes , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, "open list:MEMORY MANAGEMENT - MGLRU (MULTI-GEN LRU)" , Ridong Chen Subject: Re: [PATCH v2 2/3] mm/mglru: add tracepoint for scan_folios() Message-ID: References: <20260911102939.2485750-1-ridong.chen@linux.dev> <20260911102939.2485750-3-ridong.chen@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 09/15/26 at 08:17pm, Ridong Chen wrote: > > > On 9/15/2026 7:14 PM, Baoquan He wrote: > > On 09/11/26 at 06:29pm, Ridong Chen wrote: > > > From: Ridong Chen > > ...snip... > > > --- > > > include/trace/events/vmscan.h | 63 +++++++++++++++++++++++++++++++++++ > > > mm/vmscan.c | 6 ++++ > > > 2 files changed, 69 insertions(+) > > > > > > diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h > > > index 8a872990b4be..5defa8f6719c 100644 > > > --- a/include/trace/events/vmscan.h > > > +++ b/include/trace/events/vmscan.h > > > @@ -392,6 +392,69 @@ TRACE_EVENT(mm_vmscan_lru_isolate, > > > __print_symbolic(__entry->lru, LRU_NAMES)) > > > ); > > > +TRACE_EVENT(mm_mglru_scan_folios, > > > + > > > + TP_PROTO(struct lruvec *lruvec, > > > + int highest_zoneidx, > > > + int order, > > > + unsigned long nr_requested, > > > + unsigned long nr_scanned, > > > + unsigned long nr_sorted, > > > + unsigned long nr_skipped, > > > + unsigned long nr_taken, > > > + int lru, > > > + unsigned long max_seq, > > > + int tier, > > > + unsigned long min_seq), > > > > Thank you for your review. > > > Do we need show nid? Guess phone vendor doesn't care about multi-NUMA > > system. > > > > Eh, nid is not an mglru-specific key. Since there are 12 elements here, it > can't be added here. Hmm, we print memcg_id but not nid, it may not be so clear. How do you differentiate several lruvec-s on one memcg? I am not very familiar with trace mechanism, do we have a element number limit? Imagine I only want to trace this function, now I can see memcg_id, zone_idex, while don't know node/lruvec, that's a little pitty. Just my personal opinion, I could miss anything. > > > > And I checked v1 thread, seems Steven suggested to move the two int to > > avoid extra padding. > > > > Yeah, I will update it. I updated v2 to fix Sashiko's issue, before Steven > had any comment. > > > > > + > > > + TP_ARGS(lruvec, highest_zoneidx, order, nr_requested, nr_scanned, > > > + nr_sorted, nr_skipped, nr_taken, lru, max_seq, tier, min_seq), > > > + > > > + TP_STRUCT__entry( > > > + __field(u64, memcg_id) > > > + __field(int, highest_zoneidx) > > > + __field(int, order) > > > + __field(unsigned long, nr_requested) > > > + __field(unsigned long, nr_scanned) > > > + __field(unsigned long, nr_sorted) > > > + __field(unsigned long, nr_skipped) > > > + __field(unsigned long, nr_taken) > > > + __field(int, lru) > > > + __field(unsigned long, max_seq) > > > + __field(int, tier) > > > + __field(unsigned long, min_seq) > > > + ), > > > + > > > + TP_fast_assign( > > > + __entry->memcg_id = mem_cgroup_id(lruvec_memcg(lruvec)); > > > + __entry->highest_zoneidx = highest_zoneidx; > > > + __entry->order = order; > > > + __entry->nr_requested = nr_requested; > > > + __entry->nr_scanned = nr_scanned; > > > + __entry->nr_sorted = nr_sorted; > > > + __entry->nr_skipped = nr_skipped; > > > + __entry->nr_taken = nr_taken; > > > + __entry->lru = lru; > > > + __entry->max_seq = max_seq; > > > + __entry->tier = tier; > > > + __entry->min_seq = min_seq; > > > + ), > > > + > > > + TP_printk("memcg_id=%llu classzone=%d order=%d nr_requested=%lu nr_scanned=%lu nr_sorted=%lu nr_skipped=%lu nr_taken=%lu lru=%s max_seq=%lu tier=%d min_seq=%lu", > > > + __entry->memcg_id, > > > + __entry->highest_zoneidx, > > > + __entry->order, > > > + __entry->nr_requested, > > > + __entry->nr_scanned, > > > + __entry->nr_sorted, > > > + __entry->nr_skipped, > > > + __entry->nr_taken, > > > + __print_symbolic(__entry->lru, LRU_NAMES), > > > + __entry->max_seq, > > > + __entry->tier, > > > + __entry->min_seq) > > > +); > > > + > > > TRACE_EVENT(mm_vmscan_write_folio, > > > TP_PROTO(struct folio *folio), > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > > index 2554a6513aa8..67f59aa73fb9 100644 > > > --- a/mm/vmscan.c > > > +++ b/mm/vmscan.c > > > @@ -4876,6 +4876,12 @@ static int scan_folios(unsigned long nr_to_scan, struct lruvec *lruvec, > > > trace_mm_vmscan_lru_isolate(sc->reclaim_idx, sc->order, nr_to_scan, > > > scanned, skipped, isolated, > > > type ? LRU_INACTIVE_FILE : LRU_INACTIVE_ANON); > > > + trace_mm_mglru_scan_folios(lruvec, > > > + sc->reclaim_idx, sc->order, nr_to_scan, > > > + scanned, sorted, skipped, isolated, > > > + type ? LRU_INACTIVE_FILE : LRU_INACTIVE_ANON, > > > + lrugen->max_seq, tier, > > > + lrugen->min_seq[type]); > > > > And seems Steven also suggested to calculate lru, max_seq, min_seq in > > TP_fast_assign() in v1 which could be missed. > > > > Thanks, I will update it following Steven's suggestions. > > > > TP_fast_assign( > > __entry->memcg_id = mem_cgroup_id(lruvec_memcg(lruvec)); > > __entry->highest_zoneidx = sc->reclaim_idx; > > __entry->order = sc->order; > > __entry->nr_requested = nr_requested; > > __entry->nr_scanned = nr_scanned; > > __entry->nr_sorted = nr_sorted; > > __entry->nr_skipped = nr_skipped; > > __entry->nr_taken = nr_taken; > > __entry->lru = type ? LRU_INACTIVE_FILE : LRU_INACTIVE_ANON; > > __entry->max_seq = lrugen->max_seq; > > __entry->tier = tier; > > __entry->min_seq = lrugen->min_seq; > > ), > > > > However, 'sc' is an internal structure, so sc->order cannot be accessed in > TP_fast_assign(), and I don't think it is worth making scan_control an > external structure just for this. Agree. > > > > > > *isolatedp = isolated; > > > return scanned; > > > -- > > > 2.34.1 > > > > > -- > Best regards > Ridong >