From: Baoquan He <baoquan.he@linux.dev>
To: Kunwu Chan <kunwu.chan@gmail.com>
Cc: Baoquan He <hebaoquan@kylinos.cn>,
linux-mm@kvack.org, akpm@linux-foundation.org, chrisl@kernel.org,
kasong@tencent.com, nphamcs@gmail.com, baohua@kernel.org,
youngjun.park@lge.com, hannes@cmpxchg.org, yosry@kernel.org,
shikemeng@huaweicloud.com, chengming.zhou@linux.dev,
david@kernel.org, linux-kernel@vger.kernel.org,
Kunwu Chan <chentao@kylinos.cn>
Subject: Re: [PATCH v2 01/12] mm: xswap support for zswap
Date: Wed, 16 Sep 2026 10:52:07 +0800 [thread overview]
Message-ID: <aqoEVyxikqQ476IS@fedora> (raw)
In-Reply-To: <20260915100308.1599989-1-kunwu.chan@gmail.com>
On 09/15/26 at 06:03pm, Kunwu Chan wrote:
> On Sun, 13 Sep 2026 15:50:03 +0800 Baoquan He <hebaoquan@kylinos.cn> wrote:
...snip...
>
> The SWP_XSWAP flag and nr_real_swapfiles accounting look correct. The writeback guard
> in page_io.c (both swap_writeout and swap_read_folio paths) properly short-circuits
> xswap devices, and the zswap writeback gating on nr_real_swapfiles ensures writeback
> only fires when a real swap device is active.
>
> No issues found.
>
> Reviewed-by: Kunwu Chan <chentao@kylinos.cn>
Thanks for careful reviewing. I will post v3 soon. I found this v2 is
based on a older commit of mm-unstable, and I forgot adding base-id, so
Sashiko reviewing is failed to launch. I have rebased this onto the
latest mm-new, hope Sashiko can be satisfied.
next prev parent reply other threads:[~2026-09-16 2:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 7:50 [PATCH v2 00/12] mm, swap: extendable swap devices (xswap) Baoquan He
2026-09-13 7:50 ` [PATCH v2 01/12] mm: xswap support for zswap Baoquan He
2026-09-15 10:03 ` Kunwu Chan
2026-09-16 2:52 ` Baoquan He [this message]
2026-09-16 3:04 ` KunWu Chan
2026-09-13 7:50 ` [PATCH v2 02/12] mm, swap: add CONFIG_XSWAP and xswap fields to swap_info_struct Baoquan He
2026-09-13 7:50 ` [PATCH v2 03/12] mm, swap: refactor free_swap_cluster_info to take swap_info_struct Baoquan He
2026-09-13 7:50 ` [PATCH v2 04/12] mm, swap: add xswap cluster grow via VM_SPARSE vmalloc Baoquan He
2026-09-13 7:50 ` [PATCH v2 05/12] mm, swap: add sysfs create interface for xswap Baoquan He
2026-09-13 7:50 ` [PATCH v2 06/12] mm, swap: add xswap grow trigger on cluster allocation Baoquan He
2026-09-13 7:50 ` [PATCH v2 07/12] mm, swap: add xswap_try_shrink and shrink trigger on cluster free Baoquan He
2026-09-13 7:50 ` [PATCH v2 08/12] mm, swap: free backing pages in xswap_unmap_clusters Baoquan He
2026-09-13 7:50 ` [PATCH v2 09/12] mm, swap: defer xswap shrink to workqueue to avoid lock recursion Baoquan He
2026-09-13 7:50 ` [PATCH v2 10/12] mm, swap: refactor swapoff + add xswap_destroy Baoquan He
2026-09-13 7:50 ` [PATCH v2 11/12] mm, swap: require zswap for xswap devices Baoquan He
2026-09-13 7:50 ` [PATCH v2 12/12] mm, swap: add sysfs per-device size limit for xswap Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqoEVyxikqQ476IS@fedora \
--to=baoquan.he@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=chentao@kylinos.cn \
--cc=chrisl@kernel.org \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hebaoquan@kylinos.cn \
--cc=kasong@tencent.com \
--cc=kunwu.chan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=shikemeng@huaweicloud.com \
--cc=yosry@kernel.org \
--cc=youngjun.park@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®