From: Niklas Cassel <cassel@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: dlemoal@kernel.org, gregory.clement@bootlin.com,
hansg@kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, tj@kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] ata: libahci_platform: Fix device reference leak in ahci_platform_get_resources()
Date: Wed, 16 Sep 2026 07:29:43 +0200 [thread overview]
Message-ID: <aqopR6DfznLqgFx5@ryzen> (raw)
In-Reply-To: <178946413165.744977.6360074567141853266.b4-ty@kernel.org>
On Tue, Sep 15, 2026 at 11:22:11AM +0200, Niklas Cassel wrote:
> On Tue, 15 Sep 2026 06:59:33 +0000, Wentao Liang wrote:
> > of_find_device_by_node() takes a reference on the port platform device,
> > which is only used to look up its port regulator and is never released,
> > neither on success nor on the error paths. Drop the reference with
> > put_device() once the regulator has been obtained, which covers both the
> > success and error paths.
> >
> >
> > [...]
>
> Applied to libata/linux.git (for-7.3-fixes), thanks!
>
> [1/1] ata: libahci_platform: Fix device reference leak in ahci_platform_get_resources()
> https://git.kernel.org/libata/linux/c/26ca58db
Wentao,
Since your commit was top of tree, I took the liberty to amend your commit
to address Damien's review comment and to pick up his R-b tag, new SHA1:
https://git.kernel.org/libata/linux/c/0d1cb833
Kind regards,
Niklas
next prev parent reply other threads:[~2026-09-16 5:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 6:59 Wentao Liang
2026-09-15 9:22 ` Niklas Cassel
2026-09-16 5:29 ` Niklas Cassel [this message]
2026-09-16 2:11 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqopR6DfznLqgFx5@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=hansg@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®