From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 822D13D75C7; Wed, 16 Sep 2026 10:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789555897; cv=none; b=UmysfNHFZzhdU2o4fESCmlne3D2fUwjG4XqRWuCC3poQzKdaVJ844siFzIAm6jpmmCRkYaaUhFByT7RdF3oLsLci4Ch/vQqK/O78cawYzWYBFZildnFCh/knPwKO+Z65X61FvxoTcAaoJIDoX4p8IhxT37bic65JTBfCd560gy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789555897; c=relaxed/simple; bh=3dnspZBBhdBbFMeM0WCDXZI0ml0DomVOCTSEv9AUE24=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MERw4ZdlVtJ4j1vuYsKxNQKPQuWxy4hR6s8tIIxe+6qnLudwus2MA6JOa+pP1le+H7Awrg53g5zRCG6HC5F3ZN6djfVmacADDDvWE0bal12IDAt95U0T5crsepf5GvXO1sKOq5eqMNP/u1Vgucs/qkxQQ0Vg/WTVjIfIGdt7rGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cm/FmKsO; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cm/FmKsO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1789555893; x=1821091893; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3dnspZBBhdBbFMeM0WCDXZI0ml0DomVOCTSEv9AUE24=; b=cm/FmKsO4r56xmyw3V8634rjSzKxu5BEPdFClWZy+PZemvHd1cC8z1wS fr2MW29eNy09nFkS4t/iis/2a6TsoDqwsmJBwOx5LZjJ7Gookj6frZSNK ahZjKBQt/mXDv2Kg3L1EQHhUY1+in5qDY8tNivNcVU0fAiGykmho4WC9Z Ck3+1rpsg1cjwxPMF+wSb6T7yEA9OIT9s1TQ9D84C9Rz3niv7m/MSz6zS X1QJVxZ/uYDJfpoM45YyMgFGefawzJ5dvoO7Cajyq2KEBdSFILYPNouNf m/jf/YCln9v4qZrORUsIM6WDikavocyZPQbv6/UoXCiEWVYNsRrHEaHuv A==; X-CSE-ConnectionGUID: JNq96Cb6Tf69CoAG7FiUMw== X-CSE-MsgGUID: p4+S35ejTQ+60TVTOzHZxg== X-IronPort-AV: E=McAfee;i="6800,10657,11905"; a="90063471" X-IronPort-AV: E=Sophos;i="6.27,103,1787036400"; d="scan'208";a="90063471" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2026 03:51:27 -0700 X-CSE-ConnectionGUID: f53uaTkgRHSVd4aHVEbG+w== X-CSE-MsgGUID: siQuExozT/yqdlSyeZN/dw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,103,1787036400"; d="scan'208";a="296795155" Received: from ettammin-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.244.145]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2026 03:51:21 -0700 Date: Wed, 16 Sep 2026 13:51:19 +0300 From: Andy Shevchenko To: longzhao@ambarella.com Cc: Arnd Bergmann , Krzysztof Kozlowski , Alexandre Belloni , soc@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Jerome Brunet , Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Catalin Marinas , Will Deacon , Long Zhao , Lee Jones , mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 11/15] gpio: pl061: add Ambarella register-layout variant Message-ID: References: <20260915-cv75-v5-v7-0-3297d3fbc9c0@ambarella.com> <20260915-cv75-v5-v7-11-3297d3fbc9c0@ambarella.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260915-cv75-v5-v7-11-3297d3fbc9c0@ambarella.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Sep 15, 2026 at 07:15:41PM +0800, Long Zhao via B4 Relay wrote: > Add a 32-bit, 32-line layout with DAT/DIR/IS/IBE/IEV/IE/MIS/IC plus > MASK and ENABLE. Probe unmasks the bank and enables the controller. > IRQ type changes also clear the pending bit. This derivative does not > need write-after-direction or system suspend save/restore. > > Match the part with designer AMBA_VENDOR_AMBARELLA (JEP106 identity > 0x68, bit 7 set) and part number 0x061. Yep, this one looks nice now! Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko