From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ziran Zhang <zhangcoder@yeah.net>
Cc: "Paul E . McKenney" <paulmck@kernel.org>,
David Howells <dhowells@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Jordan R Abrahams-Whitehead <ajordanr@google.com>,
Marco Elver <elver@google.com>,
Nilay Shroff <nilay@linux.ibm.com>,
Edward Cree <ecree@solarflare.com>,
Simona Vetter <simona.vetter@ffwll.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] list: add missing empty list check to list_cut_before()
Date: Wed, 16 Sep 2026 13:53:56 +0300 [thread overview]
Message-ID: <aqp1RMcCSBftjsyn@ashevche-desk.local> (raw)
In-Reply-To: <20260916100001.10634-1-zhangcoder@yeah.net>
On Wed, Sep 16, 2026 at 06:00:01PM +0800, Ziran Zhang wrote:
> list_cut_before() lacks the list_empty() guard present
> in list_cut_position().
>
> With an empty head and an entry not on the list, it
> corrupts the list.
Is it IRL case or the code analysis? If the former, add necessary information
like hardware description (if applicable) and the important ~3-5 lines from
traceback (I assume you rung with CONFIG_LIST_DEBUG=y).
> Add the missing check. When head is empty, initialize
> @list as empty, consistent with the existing
> head->next == entry case.
Nice! Where is the test case?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-16 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 10:00 Ziran Zhang
2026-09-16 10:53 ` Andy Shevchenko [this message]
2026-09-16 11:11 ` Ziran Zhang
2026-09-16 15:37 ` Andy Shevchenko
2026-09-16 15:52 ` Ziran Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqp1RMcCSBftjsyn@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=ajordanr@google.com \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=ecree@solarflare.com \
--cc=elver@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nilay@linux.ibm.com \
--cc=paulmck@kernel.org \
--cc=simona.vetter@ffwll.ch \
--cc=zhangcoder@yeah.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®