mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Omer PALA <palaomer100@gmail.com>
Cc: andy@kernel.org, gregkh@linuxfoundation.org,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: fb_upd161704: replace udelay with usleep_range
Date: Wed, 16 Sep 2026 14:03:38 +0300	[thread overview]
Message-ID: <aqp3ihtGN5-J9TPa@ashevche-desk.local> (raw)
In-Reply-To: <20260916093928.52057-1-palaomer100@gmail.com>

On Wed, Sep 16, 2026 at 12:39:28PM +0300, Omer PALA wrote:
> Replace udelay() calls with usleep_range()
> to avoid busy-waiting and allow the
> scheduler to sleep during delays.

First of all, too condensed commit message. We have as twice room on each line.
Second, do you understand the difference on what code is doing before and after
your change?

...

Please, instead of posting patches, read first, check email archives, understand
the code...

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2026-09-16 11:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16  9:39 Omer PALA
2026-09-16  9:53 ` Nam Cao
2026-09-16 11:06   ` Andy Shevchenko
2026-09-16 12:08     ` Ömer PALA
2026-09-16 12:50       ` Nam Cao
2026-09-16 13:14         ` Ömer PALA
2026-09-16 15:17       ` Andy Shevchenko
2026-09-16 11:03 ` Andy Shevchenko [this message]
     [not found] <20260218180347.88034-1-tomasz.unger.ref@yahoo.pl>
2026-02-18 18:03 ` tomasz.unger
2026-02-19  7:30   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqp3ihtGN5-J9TPa@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=palaomer100@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®