From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bradley Morgan <brads@mainlining.org>
Cc: akpm@linux-foundation.org, andy@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] resource: Replace open coded resource_overlaps()
Date: Wed, 16 Sep 2026 10:10:31 +0300 [thread overview]
Message-ID: <aqpA50d24xu8NyGS@ashevche-desk.local> (raw)
In-Reply-To: <0D81679D-B746-405C-8333-CF0FF69E094E@mainlining.org>
On Tue, Sep 15, 2026 at 07:25:33PM +0100, Bradley Morgan wrote:
> On 15 September 2026 09:53:53 BST, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
...
> >+ pr_debug("resource sanity check: requesting %pR, which spans more than %s %pR\n",
> >+ &mem, p->name, p);
>
> This swap is not mentioned in the changelog and it does change the
> output a bit: %pa prints 0x1000, %pR pads the numbers to 10 hex digits,
> so the debug line gains a bunch of zeros. Debug only, so I don't care
> much, but a line in the changelog saying the print changed with it
> would be good?
Sure, Will do in v2.
> Other than that, LGTM
>
> Reviewed-by: Bradley Morgan <brads@mainlining.org>
Thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-16 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 8:53 Andy Shevchenko
2026-09-15 18:25 ` Bradley Morgan
2026-09-16 7:10 ` Andy Shevchenko [this message]
2026-09-17 14:03 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqpA50d24xu8NyGS@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=brads@mainlining.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®