From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9B5C49CF45; Wed, 16 Sep 2026 09:10:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=150.107.74.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789549854; cv=none; b=DzhKZj52jHHZWln3WgPHS9ZfszyiJuaFuJiooa4OJhEZOBV9/Ela2BNVlpF21i9TF9VpR2OGuU+bfmmsh9ZqONC1/n1tOV4oeOm9DHB49NVcoy5tfRy6nn/TyCOeaP2lbBAGtz3xyzqccsFXdye2DOA/7dCVzGkmTYT1CFmh6cI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789549854; c=relaxed/simple; bh=GKSilOSfggdM8g6QQVBUfLbmwTwdsDHNdb3vbfuMqoU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jay6jbw/+UiGu7UpHaIZijiBtbM5xgF6xQxXv1LtizKfrAfPupHUXsWrzQs79Osn7gi9+OkZaDHGw4ZAYqRq7Lgbli4ZefuRJh1pM+vfVkYIaA1NCOekSVkPvf9oVGT2Fdp/NViE04JQRyNq2dDCgvA4ltPikAe6wCpRhrLSegA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au; spf=pass smtp.mailfrom=gandalf.ozlabs.org; dkim=pass (2048-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b=ZFoRO0fP; arc=none smtp.client-ip=150.107.74.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gandalf.ozlabs.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="ZFoRO0fP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202608; t=1789549822; bh=pktJp8dL7X3z00M5ruTC2/04Ix43KOf7Wg32XhKGFlM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZFoRO0fPE82zDO0AA5XntPSHPUiEtPRLyVq2yURuRxipYLgRgnDqrLfZdJyC18tlo 2QenSr3PzrYAQG+ybVylQ3yNbrC8C4VzNA5McKbsIEAJm7tVRui6mJUntnactskq74 ULp4SN6l5mTUG+muug5pUsTlE+56QWKjuCmE+fvmbhzRFiqQoU3b7eshgfMVOzxBaJ TvYUkDatCPQdrMZAqZf9ozJ2gcu5heZb0ijfq4BkD8CjRjUNDLPXkNxP/kWo7GFu0r 5hjVvP4mhobwf8U5DErzIdgfM9P+3o5Rm4PJl1z5LoXKxYyxmsAII5EfpyrG2ozmJs GMDzKjYXil6NQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4hlClf40ZNz4wJj; Wed, 16 Sep 2026 19:10:22 +1000 (AEST) Date: Wed, 16 Sep 2026 18:27:53 +1000 From: David Gibson To: Herve Codina Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Laurent Pinchart , David Lechner , Ayush Singh , Geert Uytterhoeven , devicetree-compiler@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree-spec@vger.kernel.org, Hui Pu , Ian Ray , Luca Ceresoli , Thomas Petazzoni , Frank Li Subject: Re: [PATCH v3 08/15] flattree: Handle unknown tags Message-ID: References: <20260826083146.304291-1-herve.codina@bootlin.com> <20260826083146.304291-9-herve.codina@bootlin.com> <20260915121635.39f13d34@bootlin.com> <20260916083130.7b14e90e@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6GJWAqC257zHuXPW" Content-Disposition: inline In-Reply-To: <20260916083130.7b14e90e@bootlin.com> --6GJWAqC257zHuXPW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 16, 2026 at 08:31:30AM +0200, Herve Codina wrote: > Hi David, >=20 > On Tue, 15 Sep 2026 21:52:24 +1000 > David Gibson wrote: [snip] > > > This avoid the need for 2 dtbs generated by treegen and also avoid to= compare > > > binary files which are difficult to analyze when the comparison detec= ts a problem > > > due to something broken by some modifications. =20 > >=20 > > We _want_ to understand and test things at the binary byte level. > > Debugging differences is a little trickier, but it's really not that > > bad - -Odts or fdtdump or dtdiff can be used if/when there's a test > > failure. I really think doing the comparison in binary is preferable > > - that's the level at which the behaviour is specified and should be > > tested. >=20 > Right, will see what I can do. Probably generating using two specific dtbs > as suggested in your first proposal. >=20 > Worth noting that each time a dtb will change due to, for instance, a new > dtb version (or any other header field update), this test will need to be > updated. DTC will generate the dtb with new headers value. If you use the default call for the header in treegen, which always uses the latest version, then it should be fine. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --6GJWAqC257zHuXPW Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmqqUv0ACgkQzQJF27ox 2GcV3Q/+M96gs5YbYYewGX9Ulv6mDpBB1fjH499AOfIc+EXJggmkL+kos3EBZ+TD BWj8zgb5IUF+iYsEm0IxRyW6kr5WdeN7HO6N0/5KKGLsEeaueCoYzO53rVGOE/vm ySyW0+yvNruIislj9GVMlU+B/QiGkJVMevryUNyHA8yGma6CJbYeAMHfbqDBoNkB vjXbaSc/LkWWLAGaRUHtkflxDJStdxZUjr3Z3TmOH6ljDLJD90M7qiRyo0en4Ol2 wLU9H3eqhK2DV62/YPVGzR34Hz3xhPevTOMxoPG+SjUvWD/u6nFbyrW7OzTZQzE2 PcxPUWuPFeAfoB/fjj1fWO+Jz/GoHKL5p+eL26Z6Uk3B/fbNIFcvgsc1C/b0Oh0N N2fLtA1tDUst0ZCYA5OepOlwyuxnR09nmp8y6SaqBHyP+Lh1Yl6TuJSA3hdgZpAS IN7QPHO8Q3cyPlg3glGaUmAIYopNSdCm+iAKeWDri4IxvfPKKWD/ujPwNr8xjEAq Vk/OWdW5IExqevsmQctfmqqkfUx0W+pT4ZmxJeBsS2fX9YC3NCCfX/i1fKggsNv7 llgy/Wyq31q/4u1DCwrgJ+TPhptpIQNHbdIExZEfoFTvX3Rj5/w9qZdlBf5mUdLY Bl0nqBvlCUgDFdSidpaQyZnSmWi+HHrRiZeDDAMvLP7z5EVqamg= =/SJM -----END PGP SIGNATURE----- --6GJWAqC257zHuXPW--