mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ChiYuan Huang <cy_huang@richtek.com>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: <broonie@kernel.org>, <lgirdwood@gmail.com>,
	<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] regulator: rt6190: Fix runtime PM imbalance in rt6190_out_enable()
Date: Wed, 16 Sep 2026 16:46:59 +0800	[thread overview]
Message-ID: <aqpXg1TfV4ghoShD@git-send.richtek.com> (raw)
In-Reply-To: <20260916072541.1968033-1-vulab@iscas.ac.cn>

On Wed, Sep 16, 2026 at 07:25:41AM +0000, Wentao Liang wrote:
> In rt6190_out_enable(), pm_runtime_get_sync() is called at the start of
> the function. However, if any subsequent regmap or regulator operation
> fails, the function returns directly without dropping the runtime PM
> reference, causing a runtime PM reference leak.
> 
> Add an error handling path with pm_runtime_put() to keep the reference
> count balanced on failure.
> 
> Fixes: e6999e7cca7e ("regulator: rt6190: Add support for Richtek RT6190 regulator")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Reviewed-by: ChiYuan Huang <cy_huang@richtek.com>

Thanks for the fix.

      reply	other threads:[~2026-09-16  8:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16  7:25 Wentao Liang
2026-09-16  8:46 ` ChiYuan Huang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqpXg1TfV4ghoShD@git-send.richtek.com \
    --to=cy_huang@richtek.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®