mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shawn Guo <shengchao.guo@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: nord-rrd: Add sound support
Date: Wed, 16 Sep 2026 17:09:57 +0800	[thread overview]
Message-ID: <aqpc5XuF8U-m9zWm@QCOM-aGQu4IUr3Y> (raw)
In-Reply-To: <d2d2feff-4823-43dc-9014-099e69195280@oss.qualcomm.com>

On Mon, Sep 14, 2026 at 11:01:36AM +0200, Konrad Dybcio wrote:
> On 9/14/26 4:40 AM, Shawn Guo wrote:
> > From: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
> > 
> > Enable audio on the nord RRD board. Add a soundcard node using the
> > qcom,nord-ride-sndcard compatible with two DAI links:
> > 
> >   - PCM1681 playback over Tertiary MI2S RX
> >   - ADAU1979 capture over Tertiary MI2S TX
> > 
> > Add MI2S pin mux states (data, SCLK, WS on GPIO 73-76) and the MCLK0
> > pin state (GPIO 99) to nord-embedded.dtsi so they can be shared with
> > other nord board variants.
> > 
> > Add PCM1681/ADAU1979 codec nodes on I2C18, with the PCM1681 system
> > clock supplied via MCLK0. The DAC control lines come off a TCA6408 I/O
> > expander on the same bus, so add that too and hog its dac_enable and
> > click-pop-mute-n outputs, both of which have to be asserted before the
> > DAC produces sound.
> 
> Sounds like something a driver should ensure?

You are absolutely right! We will try to control them from pcm1681 and
simple-audio-amplifier driver.

Shawn

  reply	other threads:[~2026-09-16  9:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14  2:40 [PATCH 0/3] arm64: dts: qcom: Add audio support for Nord platform Shawn Guo
2026-09-14  2:40 ` [PATCH 1/3] arm64: dts: qcom: nord: Add gpr node Shawn Guo
2026-09-14  9:00   ` Konrad Dybcio
2026-09-16  6:53     ` Shawn Guo
2026-09-14  2:40 ` [PATCH 2/3] arm64: dts: qcom: nord-rrd: Add sound support Shawn Guo
2026-09-14  9:01   ` Konrad Dybcio
2026-09-16  9:09     ` Shawn Guo [this message]
2026-09-14  2:40 ` [PATCH 3/3] arm64: dts: qcom: nord-ride-embedded: " Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqpc5XuF8U-m9zWm@QCOM-aGQu4IUr3Y \
    --to=shengchao.guo@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mohammad.rafi.shaik@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®