From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: brgl@kernel.org, ckeepax@opensource.wolfsonmicro.com,
linusw@kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com,
stable@vger.kernel.org
Subject: Re: [PATCH] gpio: arizona: Fix runtime PM leak in arizona_gpio_direction_out()
Date: Wed, 16 Sep 2026 11:01:13 +0100 [thread overview]
Message-ID: <aqpo6Uyw8ZbGsx0g@opensource.cirrus.com> (raw)
In-Reply-To: <20260916094701.2007509-1-vulab@iscas.ac.cn>
On Wed, Sep 16, 2026 at 09:47:01AM +0000, Wentao Liang wrote:
> Switching a persistent GPIO line from input to output acquires a
> runtime PM reference on the parent device, but if the subsequent
> regmap_update_bits() fails the reference is never dropped and no later
> direction_in() can balance it since the direction was never changed.
> Drop the reference on the update failure path.
>
> Fixes: 27a49ed17e22 ("gpio: arizona: Add support for GPIOs that need to be maintained")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2026-09-16 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 9:47 Wentao Liang
2026-09-16 10:01 ` Charles Keepax [this message]
2026-09-17 9:51 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqpo6Uyw8ZbGsx0g@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=brgl@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®