mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: broonie@kernel.org, krzk@kernel.org, lgirdwood@gmail.com,
	linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
	patches@opensource.cirrus.com, perex@perex.cz,
	s.nawrocki@samsung.com, tiwai@suse.com, stable@vger.kernel.org
Subject: Re: [PATCH] ASoC: wm8994: Fix runtime PM imbalance in wm8994_component_probe()
Date: Wed, 16 Sep 2026 11:02:16 +0100	[thread overview]
Message-ID: <aqppKCFK8J52jciy@opensource.cirrus.com> (raw)
In-Reply-To: <20260916072737.1970990-1-vulab@iscas.ac.cn>

On Wed, Sep 16, 2026 at 07:27:37AM +0000, Wentao Liang wrote:
> In wm8994_component_probe(), pm_runtime_get_sync() is invoked before
> reading the GPIO configuration registers. If either regmap_read() fails,
> the function jumps to err_irq without calling pm_runtime_put(), leaving
> the runtime PM usage count incremented and causing a leak.
> 
> Add pm_runtime_put() on both GPIO read failure paths before jumping to
> err_irq.
> 
> Fixes: f5a2cda4f1db ("ASoC: wm8994: Ensure the device is resumed in wm89xx_mic_detect functions")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

      reply	other threads:[~2026-09-16 10:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16  7:27 Wentao Liang
2026-09-16 10:02 ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqppKCFK8J52jciy@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=s.nawrocki@samsung.com \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®