From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0EA13C4551 for ; Wed, 16 Sep 2026 12:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789561587; cv=none; b=B1KK3hnS6/fZhYKSaSVJL8xkWBbSeZ37kN+hjzBl6i4/rDvz/jtgvOn3CnAMHz/VlFnxYFQ7RfKTZSAFCqmRhwyG28I4A98MmkgVRLz3YCQEQVrI3cyS4BKzz5gnzHl42CA0H48t9/jIomXRH+sjLA82I0+J8j3yiqCsCS9Ti6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789561587; c=relaxed/simple; bh=QorOvZXFzOZ1+Fc2s37tYdEoKdEVm+Y0KI67NCN+qxc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SUrP/H3nERMQdxqbN7976cEYXsRGDBQEVrbgI8BBcydNg7LPMfPNSJc+RWE/kdaCWEzPBDBRLd7LenF3rII7pZtiPq8rr7nyTE9hlp+MjiDWAXuAV4GBW9shEp5GfAhgkxV1uRVVDPMAnttBsP7vRJzfroGERPDddSTckTQY4ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EUWkbU/P; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EUWkbU/P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAC761F00898; Wed, 16 Sep 2026 12:26:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789561586; bh=mCAlnM8+XNCHui6pLotQaszdYPa3f9MPj3y0wzrxLV4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=EUWkbU/PbkDuVf5TTjNLRNxIcgTjAdlBMWK03Uay8DcQLL/fYgMfi562LfkO3Ihwq k6JXswP1KRrRlDevh0BdHI5PES1n4iPgyaxmI2CLGO9/2ft5LwKRLWi7O//1Bv4M7B 3VMZbjOSYw9QjypmWhIgbFTXbxKlJeA8eSNpJ7Vet0pBq2Itze14gBjfQiaFWsfbJ/ EwxoOTKjR7dzt+JR7Hh4gi5AwGSKiGAFFFgH4WgXcdkl+V+0gnDbDfq0IKECoqYuRf tfO0hiMIz7szmLnN6zOBSBnWfs5kU/oEKkTenhXAQbCgoibQzBZC4C+nU7cNAuJc9r +7qjOCE1/0uCQ== Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfauth.ams.internal (Postfix) with ESMTP id CBFB61980047; Wed, 16 Sep 2026 08:26:20 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Wed, 16 Sep 2026 08:26:23 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFq6odZDDV1MbWatV/ogB8xNp9I0LZXqD9XYhLxfYbKOKS8UmtQu9jik/YJw5+uDe IQ6yOJ08HjDRPvYi9QFt1jq0pHGSfYW6nwxE+Sm7yr9nKcBmi5RUalxcvapJTiUZkcarzc Altx5IaL1NPrtSorlwPUW9SMwDvZR/9hNrEX1CWPEvmZJDDv27xZOM6Inb5XPJLhAbLlhk CcFHRQ1NHECVdbI0qiw3RFSyKV9nCbqC0DillmW/DW7U11KmKmJu9FpAeasYtIEcLsZ/VX fguKYmbKr3ea2GVW7GZmUiPj4seG2XhlkZtj5DvqTtNjjQkLAf9OUw31q4uYXd9/ZONdaw rh5IB0eMMfxuIJ5GU4VW5RxZiZFlCBX+GHbuSdIT2WoSko/DhXvqeqgvbVeFLK5dKl3CoG y946NaAYL3rRj8BN2g/qTaCLFBK/X60Es/NEcaKfNfl1z2lT+adp7hkQueGj5yWmVjRS3k o3BYRt/JZ0FZVsXQNe0zhkOnfGiwUI7joQpzKhdQs14AGWSyztUTp68Y1y20/saGhrSReD k5jecQAE2xOksfoczQ/Xqnda+qpX0gc2KgaBhXb2uvr9uPGnkeb6Pom2Fe9OPWYwEl/eJq xSkVCr9T59sRkxyX5K65Xc6oARvkSI1MRqM6OPa+UvQo79V25OKEnk0R1eMg X-ME-Proxy: Feedback-ID: i10464835:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 16 Sep 2026 08:26:19 -0400 (EDT) Date: Wed, 16 Sep 2026 13:26:18 +0100 From: Kiryl Shutsemau To: Peter Fang Cc: Dave Hansen , Rick Edgecombe , Kuppuswamy Sathyanarayanan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, Xiaoyao Li , Binbin Wu , Tony Lindgren , Sean Christopherson , Artem Bityutskiy Subject: Re: [PATCH v4 2/4] virt: tdx-guest: Calculate the Quote buffer size safely Message-ID: References: <20260915092632.2822169-1-peter.fang@intel.com> <20260915092632.2822169-3-peter.fang@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260915092632.2822169-3-peter.fang@intel.com> On Tue, Sep 15, 2026 at 02:26:01AM -0700, Peter Fang wrote: > struct tdx_quote_buf has a trailing flexible array member. > struct_size_t() calculates the size of this kind of struct safely. It > handles overflow, which helps since the Quote size comes from the host. > > Use it to rewrite the bounds check logic, since > > "header_size + data_len > buf_size" > > ...is more readable than "data_len > buf_size - header_size". > > Signed-off-by: Peter Fang > Reviewed-by: Kuppuswamy Sathyanarayanan > Reviewed-by: Tony Lindgren > Reviewed-by: Xiaoyao Li > Reviewed-by: Binbin Wu Reviewed-by: Kiryl Shutsemau (Meta) -- Kiryl Shutsemau / Kirill A. Shutemov