mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Johan Hovold <johan@kernel.org>
Cc: Joshua Crofts <joshua.crofts1@gmail.com>,
	Abel Vesa <abelvesa@kernel.org>, Peng Fan <peng.fan@nxp.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney+clk@redhat.com>,
	Jerome Brunet <jbrunet+clk@baylibre.com>,
	Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	linux-clk@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] clk: imx: add missing pm_runtime_dont_use_autosuspend() calls
Date: Wed, 16 Sep 2026 11:11:54 -0500	[thread overview]
Message-ID: <aqq_ymTi1I951uQp@SMW015318> (raw)
In-Reply-To: <aqpgUPWUGZp5Cjzt@hovoldconsulting.com>

On Wed, Sep 16, 2026 at 11:24:32AM +0200, Johan Hovold wrote:
> On Tue, Sep 15, 2026 at 10:33:43AM +0000, Joshua Crofts wrote:
> > Several drivers in the clk subsystem forget to call dont_use_autosuspend()
> > on teardown or error, causing potential resource leaks. This series adds
> > the missing calls.
>
> No, as I've explained repeatedly elsewhere, it does not cause any
> resource leaks. [1][2]
>
> The autosuspend setting leaks if you will, but that only matters in the
> theoretical corner case of someone rebinding a different driver (which
> will soon also taint the kernel).
>
> So don't exaggerate the impact, this is essentially just a cleanup,
> which is fine in itself.

Is it possilbe to create/improve runtime pm API, let runtime_pm enable/disable
include these pair functions.

I get many similar patches since scan tools is more powerful now.

Frank

>
> Johan
>
> [1] https://lore.kernel.org/all/aqpd3viN1UoZBkgL@hovoldconsulting.com/
> [2] https://lore.kernel.org/linux-iio/aow51Nk-cet9qaUQ@hovoldconsulting.com/
>

  reply	other threads:[~2026-09-16 16:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15 10:33 Joshua Crofts
2026-09-15 10:33 ` [PATCH 1/2] clk: imx: clk-imx8qxp-lpcg: add missing pm_runtime_dont_use_autosuspend() Joshua Crofts
2026-09-15 10:33 ` [PATCH 2/2] clk: imx: scu: add missing pm_runtime_dont_use_autosuspend() call Joshua Crofts
2026-09-16  9:24 ` [PATCH 0/2] clk: imx: add missing pm_runtime_dont_use_autosuspend() calls Johan Hovold
2026-09-16 16:11   ` Frank Li [this message]
2026-09-17  8:24     ` Joshua Crofts
2026-09-17  8:42       ` Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqq_ymTi1I951uQp@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=abelvesa@kernel.org \
    --cc=bmasney+clk@redhat.com \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=jbrunet+clk@baylibre.com \
    --cc=johan@kernel.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®