From: Thorsten Blum <blum@kernel.org>
To: Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Kees Cook <kees@kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: fsl_rio: Use snprintf() in fsl_rio_setup()
Date: Wed, 16 Sep 2026 23:32:50 +0200 [thread overview]
Message-ID: <aqsLAuX8mHUe5ls2@kernel.org> (raw)
In-Reply-To: <20260630144951.692473-2-thorsten.blum@linux.dev>
On Tue, Jun 30, 2026 at 04:49:50PM +0200, Thorsten Blum wrote:
> While the current code works correctly, replace the unbounded sprintf()
> with the safer snprintf() in fsl_rio_setup() to follow secure coding
> best practices.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> arch/powerpc/sysdev/fsl_rio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Gentle ping?
> diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c
> index eb55dabb4748..077c03cd93e4 100644
> --- a/arch/powerpc/sysdev/fsl_rio.c
> +++ b/arch/powerpc/sysdev/fsl_rio.c
> @@ -612,7 +612,7 @@ static int fsl_rio_setup(struct platform_device *dev)
> kfree(port);
> continue;
> }
> - sprintf(port->name, "RIO mport %d", i);
> + snprintf(port->name, sizeof(port->name), "RIO mport %d", i);
>
> priv->dev = &dev->dev;
> port->dev.parent = &dev->dev;
prev parent reply other threads:[~2026-09-16 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 14:49 Thorsten Blum
2026-08-14 12:26 ` Christophe Leroy (CS GROUP)
2026-08-14 14:46 ` Thorsten Blum
2026-09-16 21:32 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqsLAuX8mHUe5ls2@kernel.org \
--to=blum@kernel.org \
--cc=chleroy@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®