From: Carlos Llamas <cmllamas@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: tkjos@android.com, aliceryhl@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] binder: Fix up Kconfig dependancy due to removal of .c code
Date: Thu, 17 Sep 2026 09:09:03 +0000 [thread overview]
Message-ID: <aquuL7LgSwc4ySbG@google.com> (raw)
In-Reply-To: <2026091743-pony-prewar-735b@gregkh>
On Thu, Sep 17, 2026 at 09:46:44AM +0100, Greg Kroah-Hartman wrote:
> When the .c binder code was removed, building the kernel if the rust
> binder code was enabled, will cause the binder to not be built at all as
> the option changed from .c to .rs which is probably not what the
> original build wanted.
The idea was to avoid silently dropping CONFIG_ANDROID_BINDER_IPC, but I
hadn't thought about this use case you mention. I agree it's better to
keep things explicit as _RUST.
>
> Fix this up by renaming the option back to the _RUST version. If in the
> future, that suffix wants to be dropped, we can do so and then it will
> be prompted for a choice again, but for this release cycle, it should
> stay as-is.
>
> Fixes: binder: rm -f binder.c
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
Worked for me, I found no regressions. Thanks!
Tested-by: Carlos Llamas <cmllamas@google.com>
next prev parent reply other threads:[~2026-09-17 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 8:46 Greg Kroah-Hartman
2026-09-17 9:09 ` Carlos Llamas [this message]
2026-09-17 9:26 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aquuL7LgSwc4ySbG@google.com \
--to=cmllamas@google.com \
--cc=aliceryhl@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®