From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lr2-f19.google.com (mail-lr2-f19.google.com [74.125.230.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F6D54DA52E for ; Thu, 17 Sep 2026 14:29:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.83 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789655385; cv=none; b=V0jC04apCyacGmaqVu6+zUJyFi+HGEdmm8gsYb+HgntPpeGyPqPlnXlim43gWj6tp2J/xuLVNw7YjiDX/9/hESQuFGvIkWqj658XnF41Sht1xtklUjqNNnFY53wAvy0WC+LIaTz/W3euoU9h7YOYgVFrCWSGttoJekxhP95hsW0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789655385; c=relaxed/simple; bh=KK99SGOpVo0Sh2l7pX+m5thw7TySG15JTH25D7b445s=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XuDgpG29JZdI9IomDXLYXRa68QdgFV2Go1uKD8KmFzA/XJSxsYoaI6Z0MOU2XyDzR/i6fsIG05B9iU1PMyc9OL6Qfw5hw6GVoTkq837wOrvuNXcm2eKPsrvHI07WBRL5ZAmBxCm5pTFkX/iZ/rDserWCbA8w4B5vFGkTGAEdh4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=YjCZ1zJ2; arc=none smtp.client-ip=74.125.230.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="YjCZ1zJ2" Received: by mail-lr2-f19.google.com with SMTP id 38308e7fff4ca-3a30521edd8so2943631fa.1 for ; Thu, 17 Sep 2026 07:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1789655380; x=1790260180; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=jLUsM28SSrjqBmi4DDelq5Ueb0+ylvS4bDAd6TEXb10=; b=YjCZ1zJ2xBEAnj0paJGkrWY8WewXRlexrSxIG+7MouP3+uvJ+F39sfw3XuEI1rnpKk GuL54IpC0w1bCVMiiiB677P4z/XBtTV+7MLZGzh667RJy6xLGhIfakH6Tx0NBH+HuTJD EYjN5taBqcwBBsGm0uxgSmTLt+Fv6UeZNJRn2htSidUtzYDRaqfouI2Qv6dey6gJC1rT FDVOXvNHivxQOBxUL4jpBWLvZYLoF1q+xHZF4pSafZQ/UYbiHkVaOHayUiCZiQGMAxts Qy6uOJKrDoQGyOni+zbP1fRjIy834CMBO09/0AGCV7fYfxd1YurrD/WUIM+LDpQLxsIa Ho+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789655380; x=1790260180; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jLUsM28SSrjqBmi4DDelq5Ueb0+ylvS4bDAd6TEXb10=; b=enCKZb/XQOMUdeF++hNuC45T4ZIIqR9mYHu0u2zm33TTVfFvXIdjGg0ABDps1g84np qJb1eeLe/Y9/ZZX+J8yjtBY9jjlFAvsKkO9ZYaBCABPxBIUUq9BMIiwknvCjR2WRWPLZ 4CgtRD1rdcTkCBS6WG2seVvAXHmZyTHlsReMR2YalPU9qH+PI+DTH2tATsuHjxDbLK9q 9BPTRtP+PrXZ9pEnArdew2cc+QxCZwbFYyQ3KrIJLGlhYVnzIKjqE5WPYcDg4HRR4rx4 L2B1z73GiWIfYgb5VrKz8iQ+UdcRsB5NIm3lg1TxIlMjgc5cTC+FcE2KpgbaOULDeK3w XhCg== X-Forwarded-Encrypted: i=1; AKwUvByuhVWYNx0pWIqGolrovFdxLs010iK/lk9hMhL+i+vA3nQ+2vYv7h+iAAhJxHqJ0ipDjOJYI3iVbT75jr0=@vger.kernel.org X-Gm-Message-State: AFuF++m9n0j/tisKBkzFDOVHyyQtHKFGSbmRT6LOGJLru/mFDOZml4NA qk2wB863V9FCe/vrNTGRJEVrYxvxrEpn7qG5cHJs6+GbR4n329BDkoXlPlVwnKYlN7k= X-Gm-Gg: AYBFou3D/VioATCcG29EcEEZEgXKG8vxEWaAJlkgbzOlpUPaDd00ejCCGjmGuuJoyOq aOFAPv97aYuXlUyDThdOxVg5NZ8jB/WvhaTXZg2QSiUBQZmQadADSyldHj7jJ0QaUE0+UpeeQuX CVjrIMXm6l/Nc8TIWyRQQLHRUU9SxuTZRlwqniln/WZXxSqBa0id5vSeF+XX6PKGIDZ/H2pVKo4 UXTOVNe295gsz+wb6oiKy3wUme3NC32wIagnVWRWicJkNGEHY8y+5C/ek1KIyi06Ck+/DUiGt2m 4HozV0MWpOxYoirv01Xncj7E6MUFhG/QlpO2IA+WCqdHURpZgNJSemWwPE1RPh03d0tKhhbF8bn PmOkiNP+paLGM+fAlSRHCoxASOtpimITWdKdwfHBI+31AD0HQBNty/lNyY9yBGne4vdkUYXqTyM LQTPtG3ghywQpYr+OdIXAK+vpQ74qcHASZAJtB+3VDgTuUaZP4G33guIvw1T/wP4d7fGCQzBN1G YKNlw== X-Received: by 2002:a2e:bc10:0:b0:3a1:fa0f:5d21 with SMTP id 38308e7fff4ca-3a5e71460b2mr7532451fa.3.1789655379911; Thu, 17 Sep 2026 07:29:39 -0700 (PDT) Received: from localhost ([82.145.119.8]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a5dafee366sm15755461fa.42.2026.09.17.07.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2026 07:29:39 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 17 Sep 2026 16:33:18 +0200 To: Wentao Liang Cc: andrea.porta@suse.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org, saravanak@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] of: unittest: Fix np reference leak in of_unittest_pci_empty_dma_ranges() Message-ID: References: <20260917130307.2152615-1-vulab@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260917130307.2152615-1-vulab@iscas.ac.cn> Hi Wentao, On 13:03 Thu 17 Sep , Wentao Liang wrote: > of_pci_dma_range_parser_init() can fail when the node lacks a dma-ranges > property. That error path returns without dropping the reference taken > by of_find_node_by_path(). Add the missing of_node_put(). > > Fixes: 1a75e81baf4f ("of/unittest: Add empty dma-ranges address translation tests") > Cc: stable@vger.kernel.org > Signed-off-by: Wentao Liang > --- > drivers/of/unittest.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c > index 939cbff45ab1..6bc5babddf0a 100644 > --- a/drivers/of/unittest.c > +++ b/drivers/of/unittest.c > @@ -1250,6 +1250,7 @@ static void __init of_unittest_pci_empty_dma_ranges(void) > > if (of_pci_dma_range_parser_init(&parser, np)) { > pr_err("missing dma-ranges property\n"); > + of_node_put(np); > return; > } > > -- > 2.34.1 > Thanks for your patch! Reviewed-by: Andrea della Porta