From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonas Rebmann <jre@pengutronix.de>
Cc: Kees Cook <kees@kernel.org>, Andy Shevchenko <andy@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 3/5] lib/tests: string_helpers: introduce test_string_unescape_one
Date: Thu, 17 Sep 2026 15:17:50 +0300 [thread overview]
Message-ID: <aqvabt4J6jNM0ytX@ashevche-desk.local> (raw)
In-Reply-To: <1b101eed-29b3-43ee-9cf8-cfc38a5df05d@pengutronix.de>
On Thu, Sep 17, 2026 at 11:56:32AM +0200, Jonas Rebmann wrote:
> On 2026-09-17 11:08, Andy Shevchenko wrote:
> > On Thu, Sep 17, 2026 at 10:58:27AM +0200, Jonas Rebmann wrote:
> > > On 2026-09-17 09:21, Andy Shevchenko wrote:
> > > > On Wed, Sep 16, 2026 at 07:38:08PM +0200, Jonas Rebmann wrote:
...
> > > > > Add some tests for corner cases which already pass.
> > > >
> > > > So, this is two-in-one patch change. Needs a split, but I'm not sure why
> > > > we even need this. Can't your case be incorporated into the existing
> > > > "combined" variant?
> > >
> > > They can not be incorporated into the combined variant because that
> > > makes it impossible to control the size of the destination buffer. This
> > > can not be fixed because the idea of the combined test is that all test
> > > strings are combined into one buffer. The bugs fixed in this series only
> > > occur when the destination buffer is limited.
> >
> > We may modify the loop to provide the length of the destination buffer to be
> > exactly what we expect, no?
>
> The problem with test_string_unescape_combined is this array crudely
> named "strings":
I don't see the name is a big issue here, but okay, we can rename it.
> static const struct test_string strings[] = {
> {
> .in = "\\f\\ \\n\\r\\t\\v",
> .out = "\f\\ \n\r\t\v",
> .flags = UNESCAPE_SPACE,
> },
>
> ...
>
> it is not as one may expect a list of the individual tests which
> string_unescape is subjected to.
>
> Instead all of the in strings are concatenated and then string_unescape
> is called on that for each possible set of flags:
>
> string_unescape(\f\ \n\r\t\v\40\1\387\0064\05\040\8a\110\777\xv\xa\x2c\xD\x6f2\h\\\"\a\e\, out_real, 256, flags)
Yes.
> So there is no way how extending "strings" could test the code paths I
> want to test.
This is an open source, we can modify the loop to take the length into account.
Any string piece can be added to the end of it (just be located at the end of
the array. Also note, the combination of flags gives better coverage.
I'm not sure we need individual test cases in that sense. We may also add
something like printf() cases do, id est testing the result for all shortened
output buffers.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-17 12:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 17:38 [PATCH 0/5] lib/string_helpers: fixes and test cases for string_unescape() Jonas Rebmann
2026-09-16 17:38 ` [PATCH 1/5] lib/tests: string_helpers: check null terminator too Jonas Rebmann
2026-09-17 7:14 ` Andy Shevchenko
2026-09-17 8:58 ` Jonas Rebmann
2026-09-17 9:07 ` Andy Shevchenko
2026-09-16 17:38 ` [PATCH 2/5] lib/tests: string_helpers: drop unused parameters Jonas Rebmann
2026-09-17 7:18 ` Andy Shevchenko
2026-09-17 8:58 ` Jonas Rebmann
2026-09-16 17:38 ` [PATCH 3/5] lib/tests: string_helpers: introduce test_string_unescape_one Jonas Rebmann
2026-09-17 7:21 ` Andy Shevchenko
2026-09-17 8:58 ` Jonas Rebmann
2026-09-17 9:08 ` Andy Shevchenko
2026-09-17 9:56 ` Jonas Rebmann
2026-09-17 12:17 ` Andy Shevchenko [this message]
2026-09-16 17:38 ` [PATCH 4/5] lib/string_helpers: use full destination buffer in string_unescape() Jonas Rebmann
2026-09-17 7:45 ` Andy Shevchenko
2026-09-17 9:02 ` Jonas Rebmann
2026-09-17 12:32 ` Andy Shevchenko
2026-09-17 15:47 ` Jonas Rebmann
2026-09-18 6:33 ` Andy Shevchenko
2026-09-16 17:38 ` [PATCH 5/5] lib/string_helpers: fix counting of remaining bytes " Jonas Rebmann
2026-09-17 8:04 ` Andy Shevchenko
2026-09-16 21:36 ` [PATCH 0/5] lib/string_helpers: fixes and test cases for string_unescape() Andrew Morton
2026-09-16 23:13 ` Eric Biggers
2026-09-17 0:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqvabt4J6jNM0ytX@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=jre@pengutronix.de \
--cc=kees@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®