From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Salah Triki" <salah.triki@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: temperature: tsys02d: Fix state desynchronization on resolution write error
Date: Thu, 17 Sep 2026 15:23:55 +0300 [thread overview]
Message-ID: <aqvb21uRVsGNtjjx@ashevche-desk.local> (raw)
In-Reply-To: <20260917131638.000034e5@gmail.com>
On Thu, Sep 17, 2026 at 01:16:38PM +0200, Joshua Crofts wrote:
> On Thu, 17 Sep 2026 10:16:08 +0100
> Salah Triki <salah.triki@gmail.com> wrote:
...
> > - return ret;
> > + dev_data->res_index = i;
>
> You're missing a return, this will just fall through to the default
> case below.
>
> > default:
> > return -EINVAL;
...and having a such without explicit annotation will lead to a compiler
warning.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-17 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 9:16 Salah Triki
2026-09-17 11:16 ` Joshua Crofts
2026-09-17 12:23 ` Andy Shevchenko [this message]
2026-09-18 12:14 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqvb21uRVsGNtjjx@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®