From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6DCA4E5336 for ; Thu, 17 Sep 2026 17:18:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789665495; cv=none; b=iBgYnFNz8UJveSLfOMkzdNeO2r1z8IFUOsyty9nASNwNGm4dRjeal3Y3D7YmtPa1AfGf6zo/IzjkUfWTFHp+byBWKsPJ/7zLseiJUrGUy4S21WKhBiTBLf0K/4HqUFMnHmt4KKT9OUWdo3rcfmqSv06mYkiRl4HL5XFSxCpo/V8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789665495; c=relaxed/simple; bh=JSrGIbjkM8d0NQvST/BovBGlv6xJHhXtQq99el/iQKc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bg/kT7Tn5u9oZHbJZveiOKNJN05hrh9xFgB/tReVhZdwkW4YIVBV514K+Pcm76canG4v4mczGqn4iYNR3+b3lA9I7gPNWnZRvOg9P4uvmVKIXV0yd3KY/MTHR7wnIDHLVtGvH++E5dor5IBYrLLACVC/bhU1aocwoh2W06lWUv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YudlXxSM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cLTib6XH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YudlXxSM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cLTib6XH" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68HH5hUZ2553400 for ; Thu, 17 Sep 2026 17:18:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=UU3OPZ+AZXcwBF+ykx1YfK6Z 7ZZ5v6mM/Pmv+b1riFA=; b=YudlXxSMbVq1R/3U+hw0kCNdYy6DO5XxrXM66HYC eUxrlmQryFDx1VW/AMcLRuUorMWLDwcYkHz2JgXJtOYXT0SnhUROWP+gbSG9nzLQ UmSmuetkRbCqUqZqO1hoRPRnNpjtKOlTep8dsEQQXIfztW+YAABQmNAq6psXU67K k4HfRon9RnjzSDkjKsRcudzzSvpgi4gKLPdHMOYuohzZQ2D+iKCVTJlf6ATa9Zmm IiNg56w8fXBpgyIQYO/uvX9NwJ20KbtcGDOafBluYlIHZmtivJGe/t0y14bvukbt gJG34CRLYpDFgBhIYiwBJqKyfPwqGVj+KfRiy3jyKur6Mw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4grfu41jqa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 17 Sep 2026 17:18:11 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38f283baf1fso1417337a91.3 for ; Thu, 17 Sep 2026 10:18:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789665490; x=1790270290; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=UU3OPZ+AZXcwBF+ykx1YfK6Z7ZZ5v6mM/Pmv+b1riFA=; b=cLTib6XHpom/q/6450SOAP+x4+9f2kskf/XFnsNW/MuFZQtoCC5bYkkwZ6Y/EEYygM uPR+ZUzow4GJMQlAYE7fhF39XaTx3VC/04n2mkF7Itr+w/3D36KkcgQr+zAToK3dV4yS HQ0wySiylDSxtlpfmYJAb7mJJTrunlaxQEf+5Wklnf54XrTfs90Lvg8zoYqv79xshivm dayDoTgheey+7yeIefI13H6oh3wNO8f0GuLRquP6OgIXyd31vhK39ncExqaj4IMHQxOu er1WfXGJTTlnC4iwnn8mLPy5yfx+NNVNoPYzt/2s7rQrTzJmD3SNbHrT9R+vUvjnupn8 /kMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789665490; x=1790270290; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UU3OPZ+AZXcwBF+ykx1YfK6Z7ZZ5v6mM/Pmv+b1riFA=; b=GL7cCFL5mELVrSRjkmQd+6hlEKey5GtXrzsqomEs6UDlr/Ytg7B5aBZAt1wmpX2YoZ fBxb/utZtMOs3d8edu36O36PoOFEHKlJ/hl+TDSSSCOkNL/9WANHp9aDG/gf7Ya71dv8 3K5ODSuyZ4zjHfiCHGZ1NClFJph2mdltkv4ykWqN6PCk+RtbnMhLczeILyHnjc6vPvhj nrWNwzbfhwskn8z/EVZ/rK478FUWLd65YnIJ25EUiad+4/JZY43ZxIPtQehKvMC0X0MC n47clV32vJi0R2HRhRFfYZtEQ6r5R4cS4OMtOlDrgZbfJwYC2N8kaaXfPKLtgn9OhkRS ZZmA== X-Forwarded-Encrypted: i=1; AKwUvBxhfIRyQgYv1PpIvUjriaX+s/9dAG72xKQIETnFJjhncNTAV5/gvpSiY2E+NlOJd25TnbxFPvTenxqzNhY=@vger.kernel.org X-Gm-Message-State: AFuF++nLkHkOa9pGxqGksv+Qxm3ftg+0J8zQKUpuHjjPKQoh009BEnIs J1X0Wtj4JdnLG+Mp3hsM4BVbiJdGJEEJLvJyZrhzOuZP2bP2HtZOsBqSGuMMq2vs5jL0YgafGHy befU4bOBM5O57xWOlBUXIaob/nyohZz0k4AUPgQqBN6eQ+iT+gkY1D4hZdwkWTCtJMqQ= X-Gm-Gg: AYBFou2wD9pFEYwlOzdDgylot4oVEHUj2p40G90unaoFtnYYHfKEp6IHTGIETHaCAUO E0zvgjDC4yUP/SgroTHNKa5k5vh4mBEZlLK+t9Wr6w3mV9g0yYibePy9pwIVelYGPTHaE9aJFbs yqtT40BxhrhVJs/WS+InE706WdLbsLgZOMcKOe5Aa+RAF6/O6/yvlJ9puuo+f3GUlj74eR2GWYT tl9L24qRbOLCC75tSGEkVsEXrYVE3iQpNbiJydvfh30lhk2OzO8xaYeJL28vDmOM18LpfkJlEJT T9EKcREzyxZygs423ONypqAtzXSdLPm0CFmBxtjmDU3AjQZELoG/UnupbUzjK6sCVVs/trlNw7D eQdw+0zignIp9Cg== X-Received: by 2002:a17:90b:4c0d:b0:39e:464d:ebc3 with SMTP id 98e67ed59e1d1-39e464df3a0mr4120353a91.12.1789665490369; Thu, 17 Sep 2026 10:18:10 -0700 (PDT) X-Received: by 2002:a17:90b:4c0d:b0:39e:464d:ebc3 with SMTP id 98e67ed59e1d1-39e464df3a0mr4120256a91.12.1789665489670; Thu, 17 Sep 2026 10:18:09 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e35df6112sm6159114a91.7.2026.09.17.10.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2026 10:18:09 -0700 (PDT) Date: Thu, 17 Sep 2026 22:47:59 +0530 From: Mohd Ayaan Anwar To: Lorenzo Bianconi Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v2 8/9] net: stmmac: qcom-ethqos: add per-platform NOC clock voting Message-ID: References: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> <20260908-shikra_ethernet-v2-8-bbe3389d0652@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-GUID: nY0rApfw9_R5plKWODhEpL__PXbGko2U X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE3MDI0NiBTYWx0ZWRfX7rzdVeUsR1Oc A/WUJeSJG1gRITmLdpinbHR7MDQVlXARuAHvnq6fKoeHs5UXMI0aIQydYXFxO0/fBi+NxV/eWxK gdNv0xaLgv1UqWciT2KqRkAfbwM5LGw= X-Proofpoint-ORIG-GUID: nY0rApfw9_R5plKWODhEpL__PXbGko2U X-Authority-Analysis: v=2.4 cv=LbipeTfi c=1 sm=1 tr=0 ts=6aac20d3 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=oHFBo8UbpOLoADWG0oYA:9 a=CjuIK1q_8ugA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE3MDI0NiBTYWx0ZWRfX6oaiyjmH/oTI 30ZG/+548QuzFRfFRognMy444SyL8rtQ6YE0avKHaoFbgr5mKYX2ML6945p6qVrY37ajJUBRSML 744v7wV2Av0RhFdhgdK1tgsvHVUoEaDdhhTqvGyWRVrv3H9hoeQVkkrqqQxnjGTn5nag6i6+5wW lqPBQYZ7Fg71dXEpNOePCnUlAszVq9SaatJLkZgSDEAOWwcTBreQhSdBPpX9YAHMJ+Jp9TG87Zf SaiqmufHZer3n/iCY6RZ/X+b0VTB2gKFC+MTK5LCvEezgU0JkAQlF+QpFxBBw3+5pwtWOHHdFDq MNlLRLtw+Mr/uSVP2Pbfbb+jAVapg+84LfxUpTypwy3NQrSJhvOKjNso49UEiZ50zuFpL6tzIAY xSN49GnLPrMRpINQwNyG34Pet4SGsbDg0YSAyBek86DrFS+PMC1vpFFfg61wC1I9HZBVC4KgAoD CxLmgh02oGVXMF59pxg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-17_04,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 spamscore=0 priorityscore=1501 adultscore=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609170246 Hi Lorenzo, On Wed, Sep 09, 2026 at 08:47:48PM +0200, Lorenzo Bianconi wrote: > > if (enabled) { > > + if (ethqos->num_noc_clks) { > > + ret = dev_pm_opp_set_rate(ðqos->pdev->dev, > > + ethqos->noc_clk_rates[0]); > > assuming the first clock is always an OPP device seems a bit fragile to me. > Can we find a way to enforce it? (e.g. have a dedicated clk_bulk_data struct > for it). > As Konrad also pointed out in patch 9, the opp table support needs to be fixed. I will fix it for v3. > > static int qcom_ethqos_probe(struct platform_device *pdev) > > { > > struct device_node *np = pdev->dev.of_node; > > @@ -795,6 +895,12 @@ static int qcom_ethqos_probe(struct platform_device *pdev) > > ethqos->has_emac_ge_3 = data->has_emac_ge_3; > > ethqos->needs_sgmii_loopback = data->needs_sgmii_loopback; > > > > + if (data->num_noc_clks) { > > I guess you can drop this check since it is already done in > qcom_ethqos_init_noc_clks(), right? > Yes, this can be removed. Ayaan