Re: [PATCH v2] crypto/amlogic: Use devm APIs for clock management

[Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>]

On Wed, Sep 16, 2026 at 07:49:47PM +1000, Herbert Xu wrote:
> On Tue, Sep 01, 2026 at 08:12:52AM +0530, Mohamad Raizudeen wrote:
> > The driver currently gets the core clock and manually enables it using
> > clk_prepare_enable(). This requires matching calls to
> > clk_disable_unprepare() in the error paths and remove function.
> > 
> > Switch to devm_clk_get_enabled() instead. This lets the kernel handle
> > enabling and disabling the clock automatically, which allow us to drop
> > the manual cleanup code and keeps the probe function simple.
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202608310329.QgxCCMs1-lkp@intel.com/
> > Signed-off-by: Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>
> > ---
> > Changes in v2:
> > - Dropped the devm_crypto_engine_alloc_init() change due to build
> >   failure reported by the kernel test robot.
> > - Kept the devm_clk_get_enabled() clock cleanup as the sole focus of
> >   this patch.
> > - Link to v1: https://lore.kernel.org/linux-crypto/20260821151303.8150-1-raizudeen.kerneldev@gmail.com/T/#u
> > 
> >  drivers/crypto/amlogic/amlogic-gxl-core.c | 16 +++-------------
> >  1 file changed, 3 insertions(+), 13 deletions(-)
> 
> Please take a look at
> 
> https://sashiko.dev/#/patchset/20260901024302.5407-1-raizudeen.kerneldev%40gmail.com
> 
> Thanks,
> -- 
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Hi,
Thank you for pointing me to the sashiko review. I have addressed those
issues and a couple of other bugs the bot found in v3 and sent the v4
here: https://lore.kernel.org/all/20260916174227.5581-1-raizudeen.kerneldev@gmail.com/

Thanks,
Mohamad Raizudeen