mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Janani Sunil <jan.sun97@gmail.com>
Cc: "Janani Sunil" <janani.sunil@analog.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Mark Brown" <broonie@kernel.org>,
	"Marius Cristea" <marius.cristea@microchip.com>,
	"Marcus Folkesson" <marcus.folkesson@gmail.com>,
	"Kent Gustavsson" <kent@minoris.se>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-spi@vger.kernel.org, "Kent Gustavsson" <nedo80@gmail.com>
Subject: Re: [PATCH v6 5/5] iio: dac: Add AD5529R DAC driver support
Date: Wed, 30 Sep 2026 17:04:11 +0300	[thread overview]
Message-ID: <ar0W2xQ56wMFvtaE@ashevche-desk.local> (raw)
In-Reply-To: <a57399f0-4c47-4b32-bf6a-7761d9b57320@gmail.com>

On Wed, Sep 30, 2026 at 03:51:26PM +0200, Janani Sunil wrote:
> On 9/30/26 11:17, Andy Shevchenko wrote:
> > On Wed, Jul 15, 2026 at 01:41:08PM +0200, Janani Sunil wrote:
> > > Add support for AD5529R 16-channel, 12/16 bit Digital to Analog Converter
> > > from Analog Devices.
> > > 
> > > The device communicates over SPI and supports per-channel output range
> > > configuration. An optional external 4.096V reference can be used in
> > > place of the internal reference.
> > You haven't added a given tag, why?
> > 
> > In any case I have noticed that there are a number of (not so critical) issues
> > are still exists, so I have to withdraw my tag. But please, answer the above Q.
> 
> I intentionally did not carry the Reviewed-by tag from V5, because V6
> included substantial driver updates. I should have mentioned this in the
> cover letter, but I missed doing so.
> Some of the points mentioned here have already been addressed in later
> revisions and are now present in Jonathan's testing branch. I will send a
> follow up patch for the reset of the items.

Good, thanks for taking care of that.

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-09-30 14:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15 11:41 [PATCH v6 0/5] iio: dac: Add support for AD5529R DAC Janani Sunil
2026-07-15 11:41 ` [PATCH v6 1/5] spi: dt-bindings: Add spi-device-addr peripheral property Janani Sunil
2026-07-15 13:09   ` Mark Brown
2026-07-15 13:29     ` Nuno Sá
2026-07-15 13:37       ` Mark Brown
2026-07-16  9:22         ` Nuno Sá
2026-07-16 12:28           ` Mark Brown
2026-07-16 17:06             ` Conor Dooley
2026-07-17 11:51               ` Mark Brown
2026-07-17 13:52                 ` Nuno Sá
2026-07-19  2:10   ` Jonathan Cameron
2026-07-15 11:41 ` [PATCH v6 2/5] dt-bindings: iio: adc: microchip,mcp3564: Add spi-device-addr Janani Sunil
2026-07-19  2:07   ` Jonathan Cameron
2026-07-15 11:41 ` [PATCH v6 3/5] dt-bindings: iio: adc: microchip,mcp3911: " Janani Sunil
2026-07-19  2:08   ` Jonathan Cameron
2026-07-15 11:41 ` [PATCH v6 4/5] dt-bindings: iio: dac: Add AD5529R Janani Sunil
2026-07-15 11:41 ` [PATCH v6 5/5] iio: dac: Add AD5529R DAC driver support Janani Sunil
2026-07-15 22:22   ` Uwe Kleine-König
2026-07-19  2:19   ` Jonathan Cameron
2026-09-30  9:17   ` Andy Shevchenko
2026-09-30 13:51     ` Janani Sunil
2026-09-30 14:04       ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ar0W2xQ56wMFvtaE@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jan.sun97@gmail.com \
    --cc=janani.sunil@analog.com \
    --cc=jic23@kernel.org \
    --cc=kent@minoris.se \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marcus.folkesson@gmail.com \
    --cc=marius.cristea@microchip.com \
    --cc=nedo80@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®