From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f37.google.com (mail-pz2-f37.google.com [74.125.228.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A3A251356C for ; Wed, 30 Sep 2026 17:09:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.37 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790788144; cv=none; b=JPAIosNkjDCqG5Lauvki21IMfZAhHgLX0IPCfWDyFeCPp987Gcb2iTijBUG8AgR0ZxJ852/gZsC0+aLxGI2NloYNkaN0gIpUUCmV668GiL3Db6v92BpzDgyR9xJnKb8hndSPHFI5FdJRHDRbr6WDJL6yG2s1aqyXeh3W3I/sHNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790788144; c=relaxed/simple; bh=ktfBIjCa0CIvknEpl0ZQy+RUTPio7skXi7Noh7PuGm0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G9x98FA63m1DR+To2m5+8ehu46vdg8VcBlv2v2sFpOXQ/p9EBCE+7EhUHLGBToVZ7c1uk9nAYWXkd7RhtbkQPmVgX3+mt1UsIABFLQSkaQXwqt6Sn3a2IbL1COghXbcVvrcWKyjgWdPVwogXlJcszDvSxiBy1yBduoBnxbA+zIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=Ys77FQGQ; arc=none smtp.client-ip=74.125.228.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="Ys77FQGQ" Received: by mail-pz2-f37.google.com with SMTP id d2e1a72fcca58-887c067c816so255819b3a.2 for ; Wed, 30 Sep 2026 10:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1790788141; x=1791392941; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:mail-followup-to:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=t6oCiS1uRC3fuq7qwf3HrQZfaTBzywLk4ZFO46jPFa8=; b=Ys77FQGQ3zkjzjgLDJIQVf7ow6K4HY/PD29wz4z5n1NBOVMXKEDSkbEUKkZfrLabEd NsyXrmFlrWXxVkMdsHe3FGeTMigsde1zhO/k4F1YhUKrnivGOal8Gmw1pX5vsnzEh06e LMSCjY/Nmby7PDCdGqnu5UFYlckcbuZ6Pg9q5DIB7Wg6AGEnt9KRavrol1Au0h1HqTRF BXC9FXJFI1zf5eM46zEClJ5eYs53UhzTydATJ6lu6HQeoIO1iZ7XkA9H93NC9CoY+Vk4 TxU+11do906IXflCqyKglWAAbWVHoRgRcj8/ia+hIUYuNJFaf5ARhn0xOouWgzPjPpDE uXKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790788141; x=1791392941; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:mail-followup-to:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=t6oCiS1uRC3fuq7qwf3HrQZfaTBzywLk4ZFO46jPFa8=; b=qwdIOjATbA77xVw35E2QOZW3k04G/gBVqhfW85z0GJs8NH9yZFnwQ55DxexOcwz5pD 6u5pWxWvX2Q0JPc0f9RG0IKS7OAMvV6M6LRMqc5fRTe4CTpw4NAI3bxoQxQJN/3gMnxF ngNIj3jfKKONBaaBVUnEdkzkHJbKkGMqILsTukdWyFAw/LB+h0duL9V8VRjhASShOPI3 yG419XomnOaHprJWN9MkM+kiT8dut/+8V6AUvW2dRLkv74ZgmMjum5+pD7Bdxk0PPaL7 dfgzTOtVvSu4KIVIAfmA6Kyc/cUs2k81EznK0PSnHQv0k5cCkSu6hEyham56MpWrD+YA a/pQ== X-Forwarded-Encrypted: i=1; AKwUvBy4rrOzygEF14ZXIOZkgxBRUKPFOzeq2IN/RqHhKUETm4Sx/+fkAZ1wMs9Rk2Q+9/LUC1ORoMWdzCW3p1U=@vger.kernel.org X-Gm-Message-State: AFuF++lE0pcBLDC4aHZvM7i0PS/a7L933V9wzK26Wl2uhhwqJJqVMFt2 g2bjRaY/hKxEeCW4Kcn77xQuAzBc01mndW+K4arNbqfEfNQ0BOytsvQRtWjKu4o3kus= X-Gm-Gg: AYBFou3BZokPYpOwRaLe0K4rkBkGexkxr9a176nYhdcY3y5VTZUoqjMIEKXypDx0KOH 6BLR7sgRGKer2/1O4AitAZRGmgKodi9pKHEi0uIdiv/tzu2gej0Zb6CF9JHDfGqgKDUT5b//XdO 37Fw4iJBnSPOt2WezmHXkTaJCL28uW4NEuvTDauSxdp6QTOfkWW8u+YHILG+f9QGwBEU4NiuaWV wft312MgzyDfR/Z5KbsMjso73RS1Zg2Btq1iHBc1D+TxQjtXtZC7eIFjAuerbwxvqsuDDzNIsjl AC1GDr/WBE/1ZHVzr4oMs6e4t/THXgFLl9fu2fqSifgqKkg11w6dyN1MWAGOPVWauOSu1GADLOT EjjEUPTULsVZITHzLkRrzYJcW49lxsuUGUlKig0Wc9joM/I7nrv1wOip9q2t7fzmnEd34bQQLTH dVGRWiTk514t0mCLmpj8XzsBcnlRX/zN0TqcGoNdtiQ1c0J95n3oA1bDXiVBOaX2e3hixV9Il37 JqHn85X X-Received: by 2002:a05:6a00:1415:b0:880:849d:c07c with SMTP id d2e1a72fcca58-8874b065cfdmr1588192b3a.25.1790788140806; Wed, 30 Sep 2026 10:09:00 -0700 (PDT) Received: from localhost ([2a03:2880:2ff::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-88725d63827sm1236665b3a.33.2026.09.30.10.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 10:09:00 -0700 (PDT) Date: Wed, 30 Sep 2026 10:08:59 -0700 From: Joe Damato To: =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= Cc: Alexander Duyck , Jakub Kicinski , kernel-team@meta.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Shuah Khan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Daniel Borkmann , "Mike Marciniszyn (Meta)" , Mohsin Bashir , Stanislav Fomichev , Bobby Eshleman , Dimitri Daskalakis , Weiming Shi , Maxime Chevallier , Jacob Keller , Breno Leitao , Tao Cui , Pavel Begunkov , David Wei Subject: Re: [PATCH net-next v4 2/5] fbnic: Track BDQ device-page geometry per ring Message-ID: Mail-Followup-To: Joe Damato , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Alexander Duyck , Jakub Kicinski , kernel-team@meta.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Shuah Khan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Daniel Borkmann , "Mike Marciniszyn (Meta)" , Mohsin Bashir , Stanislav Fomichev , Bobby Eshleman , Dimitri Daskalakis , Weiming Shi , Maxime Chevallier , Jacob Keller , Breno Leitao , Tao Cui , Pavel Begunkov , David Wei References: <20260925104417.2325213-1-bjorn@kernel.org> <20260925104417.2325213-3-bjorn@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260925104417.2325213-3-bjorn@kernel.org> On Fri, Sep 25, 2026 at 12:44:09PM +0200, Björn Töpel wrote: > fbnic derives the BDQ buffer layout from PAGE_SIZE. That decides at > build time how a posted page is split into 4 KiB device pages, and > uses the same completion decoding for HPQ and PPQ. That is wrong once > the queues use different posted-page sizes; completions must be > decoded with the geometry of the queue that produced them. > > Keep PAGE_SIZE as the posted-page size for both queues in this change, > so the descriptor format and runtime behavior stay unchanged. > > Signed-off-by: Björn Töpel > Reviewed-by: Breno Leitao > --- > drivers/net/ethernet/meta/fbnic/fbnic_csr.h | 34 ++------ > .../net/ethernet/meta/fbnic/fbnic_debugfs.c | 5 +- > drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 83 ++++++++++++------- > drivers/net/ethernet/meta/fbnic/fbnic_txrx.h | 6 ++ > 4 files changed, 72 insertions(+), 56 deletions(-) Reviewed-by: Joe Damato