From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Swapnil Sapkal <swapnil.sapkal@amd.com>
Cc: Tianyi Chen <hi@tychen.cc>, Namhyung Kim <namhyung@kernel.org>,
irogers@google.com, ravi.bangoria@amd.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf sched stats: Reject mismatched or incomplete snapshots
Date: Wed, 30 Sep 2026 20:06:22 +0200 [thread overview]
Message-ID: <ar1Pnn1EtP030Pq1@x2> (raw)
In-Reply-To: <a7b96474-98b0-49b4-a524-89bda593275f@amd.com>
On Mon, Sep 28, 2026 at 06:57:43PM +0530, Swapnil Sapkal wrote:
> On 25-09-2026 18:37, Arnaldo Carvalho de Melo wrote:
> > On Thu, Sep 17, 2026 at 12:11:25AM +0800, Tianyi Chen wrote:
> > > Identify the second snapshot by its timestamp or CPU ordering, and
> > > require matching CPU/domain IDs and versions before subtracting. Check
> > > that every record has a counterpart before printing, and propagate
> > > errors from either input of diff.
> > > Add a shell test with synthetic snapshots, including equal timestamps,
> > > CPU filtering, and missing or reordered CPU/domain records.
> > > Fixes: 5a357ae6ad63 ("perf sched stats: Add support for report subcommand")
> > Swapnil, can you please ack/review this one?
> I have reviewed and tested the changes. It looks good to me. Please feel
> free to add
> Reviewed-and-tested-by: Swapnil Sapkal <swapnil.sapkal@amd.com>
Thanks, applied to perf-tools-next, for v7.4.
- Arnaldo
prev parent reply other threads:[~2026-09-30 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 16:11 Tianyi Chen
2026-09-25 13:07 ` Arnaldo Carvalho de Melo
2026-09-28 13:27 ` Swapnil Sapkal
2026-09-30 18:06 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar1Pnn1EtP030Pq1@x2 \
--to=acme@kernel.org \
--cc=hi@tychen.cc \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=ravi.bangoria@amd.com \
--cc=swapnil.sapkal@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®