mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	 "Liam R. Howlett" <liam@infradead.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	 Jann Horn <jannh@google.com>, Pedro Falcato <pfalcato@suse.de>,
	 Brian Geffon <bgeffon@google.com>,
	Minchan Kim <minchan@kernel.org>,
	 Kiryl Shutsemau <kas@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	 stable@vger.kernel.org
Subject: Re: [PATCH 0/2] mm/mremap: fix two issues with MREMAP_DONTUNMAP
Date: Wed, 30 Sep 2026 19:24:03 +0100	[thread overview]
Message-ID: <ar1TdGugvi9_RwG9@gremlin> (raw)
In-Reply-To: <ar0y2odPFkCLMKk6@gremlin>

On Wed, Sep 30, 2026 at 05:04:38PM +0100, Lorenzo Stoakes (ARM) wrote:
> On Wed, Sep 30, 2026 at 10:59:50AM -0500, Anirudh Srinivasan wrote:
> > On Sun, Sep 20, 2026 at 03:13:09PM +0100, Lorenzo Stoakes (ARM) wrote:
>
> > > Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> > > ---
> > > Lorenzo Stoakes (ARM) (2):
> > >       mm/mremap: fix locked_vm leak from MREMAP_DONTUNMAP self-merge
> > >       mm/mremap: fix locked_vm leak by splitting VMA for MREMAP_DONTUNMAP
> >
> > Hello,
> >
> > Apologies for the double mail. I did not hit reply all first time.
> >
> > I am seeing some failures in the proc_maps_race kselftests after
> > this patch was added to linux-next. The failures are in
> > test_maps_tearing_from_remap and test_maps_tearing_from_resize. I have
> > attached some logs below
>
> Ack thanks for the report. I'll dig into this and get back to you!
>
> Instinctively I suspect the tests are making assumptions they shouldn't be,
> given this series has the MREMAP_DONTUNMAP case split in advance.

OK, the tests seem fairly sensitive to change, but the correct solution here
overall I think is to only split if the VMA is mlock()'d, so I'll do that and
send a respin + cc you on that which you can check!

That should fix the tests and avoids unnecessary splits also.

Thanks again for the report! :)

>
> --
> Cheers, Lorenzo

--
Cheers, Lorenzo

      reply	other threads:[~2026-09-30 18:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20 14:13 Lorenzo Stoakes (ARM)
2026-09-20 14:13 ` [PATCH 1/2] mm/mremap: fix locked_vm leak from MREMAP_DONTUNMAP self-merge Lorenzo Stoakes (ARM)
2026-09-27 14:53   ` Jose A. Perez de Azpillaga
2026-09-28 10:45   ` Kiryl Shutsemau
2026-09-28 10:47     ` Lorenzo Stoakes (ARM)
2026-09-28 11:00   ` Pedro Falcato
2026-09-20 14:13 ` [PATCH 2/2] mm/mremap: fix locked_vm leak by splitting VMA for MREMAP_DONTUNMAP Lorenzo Stoakes (ARM)
2026-09-27 15:06   ` Jose A. Perez de Azpillaga
2026-09-28 11:01   ` Kiryl Shutsemau
2026-09-28 11:08   ` Pedro Falcato
2026-09-26 20:53 ` [PATCH 0/2] mm/mremap: fix two issues with MREMAP_DONTUNMAP Andrew Morton
2026-09-30 15:59 ` Anirudh Srinivasan
2026-09-30 16:04   ` Lorenzo Stoakes (ARM)
2026-09-30 18:24     ` Lorenzo Stoakes (ARM) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ar1TdGugvi9_RwG9@gremlin \
    --to=ljs@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=asrinivasan@oss.tenstorrent.com \
    --cc=bgeffon@google.com \
    --cc=jannh@google.com \
    --cc=kas@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=pfalcato@suse.de \
    --cc=stable@vger.kernel.org \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®