From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: "Barnabás Pőcze" <barnabas.pocze+renesas@ideasonboard.com>
Cc: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Jacopo Mondi" <jacopo.mondi+renesas@ideasonboard.com>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: rcar-isp: ispcore: Fix inconsistent step sizes
Date: Thu, 1 Oct 2026 13:34:03 +0300 [thread overview]
Message-ID: <ar43Gx4cm_bKLC0b@kekkonen.localdomain> (raw)
In-Reply-To: <20261001085130.84565-1-barnabas.pocze+renesas@ideasonboard.com>
Hi Barnabás,
On Thu, Oct 01, 2026 at 10:51:30AM +0200, Barnabás Pőcze wrote:
> `risp_io_{input,capture}_enum_framesizes()` sets the horizontal and vertical
> step size to 2. However, `risp_io_{input,capture}_try_format()` passes 2
> to `v4l_bound_align_image()`, which corresponds to a step size of 2^2 = 4.
>
> So move these constants into macros to avoid the repetition, and with that,
> use 4 as the step size everywhere.
>
> Fixes: 2151350f60d1 ("media: rcar-isp: Add support for ISPCORE")
> Signed-off-by: Barnabás Pőcze <barnabas.pocze+renesas@ideasonboard.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
I already have v1 in my tree and I don't think there's a need to fix that
tiny typo just for the typo itself.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2026-10-01 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 8:51 Barnabás Pőcze
2026-10-01 10:34 ` Sakari Ailus [this message]
2026-10-04 9:14 ` Jacopo Mondi
2026-10-05 8:55 ` Barnabás Pőcze
2026-10-05 9:24 ` Jacopo Mondi
2026-10-05 16:08 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar43Gx4cm_bKLC0b@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=barnabas.pocze+renesas@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=jacopo.mondi+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®