From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Jann Horn <jannh@google.com>, Pedro Falcato <pfalcato@suse.de>,
Brian Geffon <bgeffon@google.com>,
Minchan Kim <minchan@kernel.org>,
Kiryl Shutsemau <kas@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>,
stable@vger.kernel.org,
"Jose A. Perez de Azpillaga" <azpijr@gmail.com>
Subject: Re: [PATCH v2 0/2] mm/mremap: fix two issues with MREMAP_DONTUNMAP
Date: Thu, 1 Oct 2026 09:05:36 +0100 [thread overview]
Message-ID: <ar4T2vmGD1vZfAaI@gremlin> (raw)
In-Reply-To: <20260930152139.e8fc193b9c2880b625fda814@linux-foundation.org>
On Wed, Sep 30, 2026 at 03:21:39PM -0700, Andrew Morton wrote:
> On Wed, 30 Sep 2026 19:47:08 +0100 "Lorenzo Stoakes (ARM)" <ljs@kernel.org> wrote:
> > v2:
> > * Added tags (thanks everybody!)
> > * Updated 2/2 to avoid splitting the VMA if the VMA was not mlock()'d. It
> > is only meaningful and necessary to perform the split in this case. This
> > also fixes the proc_maps_race selftests that broke, as reported by
> > Anirudh.
>
> Here's how v2 altered mm.git's mm-hotfixes-unstable branch. Quite a
> large change - are you sure that retaining the tags was appropriate?
It's not a large change conceptually.
The dontunmap_complete() delta is just reverting it to what it was before.
The rest of it is literally just checking for VMA_LOCKED_BIT to avoid an
unnecessary split.
So yeah I think fine to retain tags.
--
Cheers, Lorenzo
prev parent reply other threads:[~2026-10-01 8:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 18:47 Lorenzo Stoakes (ARM)
2026-09-30 18:47 ` [PATCH v2 1/2] mm/mremap: fix locked_vm leak from MREMAP_DONTUNMAP self-merge Lorenzo Stoakes (ARM)
2026-09-30 18:47 ` [PATCH v2 2/2] mm/mremap: fix locked_vm leak by splitting VMA for MREMAP_DONTUNMAP Lorenzo Stoakes (ARM)
2026-09-30 19:15 ` [PATCH v2 0/2] mm/mremap: fix two issues with MREMAP_DONTUNMAP Anirudh Srinivasan
2026-10-01 8:10 ` Lorenzo Stoakes (ARM)
2026-09-30 22:21 ` Andrew Morton
2026-10-01 8:05 ` Lorenzo Stoakes (ARM) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar4T2vmGD1vZfAaI@gremlin \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=asrinivasan@oss.tenstorrent.com \
--cc=azpijr@gmail.com \
--cc=bgeffon@google.com \
--cc=jannh@google.com \
--cc=kas@kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=pfalcato@suse.de \
--cc=stable@vger.kernel.org \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®