From: Thierry Reding <thierry.reding@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: Jiale Yao <yaojiale02@163.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 0/4] pinctrl: free maps on DT mapping failures
Date: Thu, 1 Oct 2026 14:42:19 +0200 [thread overview]
Message-ID: <ar5U-FseGCtU3mp2@orome> (raw)
In-Reply-To: <CAD++jLkTzLm00UKdUZuxWidNUppQM=Fge-dUgDJGB-NdRVEn9w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]
On Thu, Oct 01, 2026 at 09:49:09AM +0200, Linus Walleij wrote:
> On Thu, Sep 24, 2026 at 1:19 PM Jiale Yao <yaojiale02@163.com> wrote:
>
> > Several pinctrl drivers reserve map storage before appending mux and
> > configuration entries while translating device tree nodes. If a later
> > operation fails, their error paths free only temporary configuration data
> > and leave the partially built map allocated.
> >
> > Commit 17007cd700601777d9ee203a13d97e64ece3a10f fixed the same cleanup
> > problem in the generic mapping helper. These drivers use their own mapping
> > callbacks and need equivalent error handling.
> >
> > Free the accumulated map and clear the output parameters on every failure
> > path in the Spreadtrum, Renesas RZ/N1, Tegra XUSB, and Samsung drivers.
> > Each patch changes one driver and remains independently buildable.
>
> Patches applied as nonurgent fixes.
Jiale said they were going to update this to drop the useless reset of
the output parameters. Those changes should probably be integrated into
the patches you apply. Could of course be a follow-up, too.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-10-01 12:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 11:18 Jiale Yao
2026-09-24 11:18 ` [PATCH 1/4] pinctrl: sprd: free maps on DT map failure Jiale Yao
2026-09-29 6:08 ` Baolin Wang
2026-09-24 11:18 ` [PATCH 2/4] pinctrl: renesas: rzn1: " Jiale Yao
2026-09-28 13:19 ` Geert Uytterhoeven
2026-09-29 8:07 ` jiale yao
2026-10-01 12:45 ` Thierry Reding
2026-09-24 11:18 ` [PATCH 3/4] pinctrl: tegra: xusb: " Jiale Yao
2026-09-24 11:18 ` [PATCH 4/4] pinctrl: samsung: " Jiale Yao
2026-10-01 7:49 ` [PATCH 0/4] pinctrl: free maps on DT mapping failures Linus Walleij
2026-10-01 12:42 ` Thierry Reding [this message]
2026-10-01 19:47 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar5U-FseGCtU3mp2@orome \
--to=thierry.reding@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=geert+renesas@glider.be \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=yaojiale02@163.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®