mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Andi Shyti <andi.shyti@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: core: document preference for i2c_get_adapter_by_fwnode()
Date: Thu, 1 Oct 2026 15:03:37 +0200	[thread overview]
Message-ID: <ar5aKUz1BMiMP9Wl@hovoldconsulting.com> (raw)
In-Reply-To: <am5dvgXS09CA3ohj@shikoro>

[-- Attachment #1: Type: text/plain, Size: 994 bytes --]

On Sat, Aug 01, 2026 at 10:57:34PM +0200, Wolfram Sang wrote:
> On Thu, Jul 16, 2026 at 03:30:29PM +0200, Johan Hovold wrote:
> > The i2c subsystem currently blocks during adapter deregistration
> > whenever there are consumers holding a reference.
> > 
> > Document that i2c_get_adapter_by_fwnode(), which also takes a module
> > reference, should almost always be preferred over
> > i2c_find_adapter_by_fwnode() so that an attempt to unload the adapter
> > module while in use fails gracefully instead of blocking
> > uninterruptibly.
> > 
> > Note that by implication of_get_i2c_adapter_by_node() is also generally
> > preferred over of_find_i2c_adapter_by_node().
> > 
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> 
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Andi, I would suggest to apply it to for-current even, because this is
> an important doc update,  but I'll leave it to you, of course.

Can this one be picked up now?

Johan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]

      reply	other threads:[~2026-10-01 13:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 13:30 Johan Hovold
2026-08-01 20:57 ` Wolfram Sang
2026-10-01 13:03   ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ar5aKUz1BMiMP9Wl@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®