mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: CL Wang <cl634@andestech.com>
Cc: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Frank Li <Frank.Li@kernel.org>, Kees Cook <kees@kernel.org>,
	"Gustavo A . R . Silva" <gustavoars@kernel.org>,
	tim609@andestech.com, dmaengine@vger.kernel.org,
	devicetree@vger.kernel.org, linux-hardening@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v8 1/2] dt-bindings: dmaengine: Add support for ATCDMAC300 DMA engine
Date: Thu, 1 Oct 2026 15:57:10 -0400	[thread overview]
Message-ID: <ar67FuFDeVQe0-wp@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20261001014503.786490-2-cl634@andestech.com>

On Thu, Oct 01, 2026 at 09:45:02AM +0800, CL Wang wrote:
> Document devicetree bindings for Andes ATCDMAC300 DMA engine
>
> ATCDMAC300 is the IP name, which is embedded in AndesCore-based
> platforms or SoCs such as AE350 and Qilai.
>
> Signed-off-by: CL Wang <cl634@andestech.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> ---
>   Changes for v7:
>     - Rebase onto the current dmaengine/next; no changes from v6
>
>   Changes for v6:
>     - Rebase onto dmaengine/next; no changes from v5
>
>   Changes for v5:
>     - No changes from v4
>
>   Changes for v4:
>     - Use items list format with descriptions for reg property
>       as suggested by Conor Dooley
>
>   Changes for v3:
>     - Rename DT binding file from andestech,qilai-dma.yaml to
>       andestech,ae350-dma.yaml.
>     - Deprecate IP-core-based compatible usage and align with
>       SoC/platform-based strings.
>     - Dropped Acked-by tag from Conor Dooley due to the above change.
> ---
>  .../bindings/dma/andestech,ae350-dma.yaml     | 67 +++++++++++++++++++
>  1 file changed, 67 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/dma/andestech,ae350-dma.yaml
>
> diff --git a/Documentation/devicetree/bindings/dma/andestech,ae350-dma.yaml b/Documentation/devicetree/bindings/dma/andestech,ae350-dma.yaml
> new file mode 100644
> index 000000000000..f040a2bf7d4b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/andestech,ae350-dma.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/andestech,ae350-dma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Andes ATCDMAC300 DMA Controller
> +
> +maintainers:
> +  - CL Wang <cl634@andestech.com>
> +
> +allOf:
> +  - $ref: dma-controller.yaml#
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - andestech,qilai-dma
> +          - const: andestech,ae350-dma
> +      - const: andestech,ae350-dma
> +
> +  reg:
> +    minItems: 1
> +    items:
> +      - description: DMA controller register range
> +      - description: cache control in IOCP controller
> +
> +  reg-names:
> +    minItems: 1
> +    items:
> +      - const: dma
> +      - const: iocp
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  "#dma-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - "#dma-cells"
> +
> +additionalProperties: false

According to Documentation/devicetree/bindings/writing-bindings.rst
ref to other yaml(ref: dma-controller.yaml)

should use
unevaluatedProperties: false

Frank
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        dma-controller@f0c00000 {
> +            compatible = "andestech,ae350-dma";
> +            reg = <0x0 0xf0c00000 0x0 0x1000>,
> +                  <0x0 0xe8000000 0x0 0x10>;
> +            reg-names = "dma", "iocp";
> +            interrupts = <10 IRQ_TYPE_LEVEL_HIGH>;
> +            #dma-cells = <1>;
> +        };
> +    };
> +...
> --
> 2.34.1
>

  reply	other threads:[~2026-10-01 19:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01  1:45 [PATCH v8 0/2] dmaengine: atcdmac300: Add Andes ATCDMAC300 DMA driver CL Wang
2026-10-01  1:45 ` [PATCH v8 1/2] dt-bindings: dmaengine: Add support for ATCDMAC300 DMA engine CL Wang
2026-10-01 19:57   ` Frank Li [this message]
2026-10-01 21:12     ` Conor Dooley
2026-10-01  1:45 ` [PATCH v8 2/2] dmaengine: atcdmac300: Add driver for Andes ATCDMAC300 DMA controller CL Wang
2026-10-01 20:18   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ar67FuFDeVQe0-wp@lizhi-Precision-Tower-5810 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@kernel.org \
    --cc=cl634@andestech.com \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=gustavoars@kernel.org \
    --cc=kees@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tim609@andestech.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®