From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f38.google.com (mail-pj2-f38.google.com [74.125.227.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FB353D45F7 for ; Thu, 1 Oct 2026 20:06:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.166 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790885191; cv=none; b=ZRM/NXxAXxNg3YDJB3R5vLcZlAT1asMxwwDToZNrmDlzomLpUGMn1/U8H5upgFrKm8bfLUtFTuuJBjAh8ga68yvxVESiyraYv3Mignrd6/yioTFPHHHuY8E42kLmVg4VOoRP8Q1y2PuOIzhM6TLpqO6Z1TH/jss5Jy3a0wniNlM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790885191; c=relaxed/simple; bh=itH6vbMqVbMJFlSOzycQd4i1lZJJhxPN2ByoF1230/I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UPG3Fbo06NHkPGK6gdEAGvUXD75/MFR3WIVU7VYNh+nWCwTY6T6gr1k8EBKeCeiDAzpH/KeYgh8BtR0pmNSoiuYYuE4/dHGsDHaF5nc/ZX1WQ+eajtyPZrfT0OAiKuOtyzGEMW9KOzPk9eawanGs1bQTKtJ/KgBCd5Mpm8ES3pY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=w9rMd0Hk; arc=none smtp.client-ip=74.125.227.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="w9rMd0Hk" Received: by mail-pj2-f38.google.com with SMTP id 98e67ed59e1d1-3a4b4770191so1605952a91.2 for ; Thu, 01 Oct 2026 13:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1790885188; x=1791489988; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=grsKZ1OSZx24kS0KKL4KN4ISoNfQyaFFM1VYosHh8gg=; b=w9rMd0Hk+ZowXQ/lND2xLY7F3ULhmQarHLxnV8DxrNfYf6fnLC7OVT/rKuVneGV0pr bu24hYzRhqZrmlLBHkwHumGGwxBsFmLh6TEiF0tGqgefrJFgTKJX4An4IG5fz6yHHXiU BF47F1Sm/NO8tFdFldO8VxSnSK+wX7NZpBm2+ZEmsMEPIDIK0iZbxgalzK4Q1F1Bhw2D XSIW5vRGss3h1EzK/JT0+5ruit9zGmwJ6eFQkb9Y9pZHcfUSdpNtlYmwmXXLz4YpcMvw i6yhw63usOXO7nCMaOZusvC6RH0VhOMJxW2K94TffckNPbBVGqHeBS1m+YjRZ2wVBi97 KDig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790885188; x=1791489988; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=grsKZ1OSZx24kS0KKL4KN4ISoNfQyaFFM1VYosHh8gg=; b=Nx3Ovpx1RnMJxHF6Q69GJWmivfAYe66dS5h2ndKORaVEuG2gVJ62s9wDRtMy7skHMk s17A+kpCwxqNMZ17jQxU0dGBpGvqpUfMNt/a+AXdeLX7BKM6aTeqgHCmVMQLDx6nXu+L v7SjqE5haCmOpRqpkQ+ZlrxFw/cgx7OvJsIjyc6kyFxXYOMWQ/GRtdyy6sX+4y52BfXB qw7gELHP3/iy+/ntFzgL2bYJYgtcu7mPAqi/pgvNfWxdKYsqf3dwzRMO8hozHYVQ7Glf vhWzhbPjQuOuQ/pHfmLQV/Ys3GpVnbn8w34kCRIr+y4l7v8jwe63kiEuNStuNr3hZKov ba+Q== X-Forwarded-Encrypted: i=1; AKwUvBwVIe+vdea3XDc4p+GiJjtR/SRWO2EHyxbtXKcQTsKobx/NqJ11WaRGXTlKZiAkJfxlwZCx8FFboVo3JkM=@vger.kernel.org X-Gm-Message-State: AFq9FYLpwmwswQpRUrRAzwxvWqCGon7bEqcfTWD2jtNBo/OyJ5vTnGZF 1jKBdEp9ZjpQUjA4cA5VlPmQLSVLwdonzqSOvKekQ2rfVIunWAxT+sDcehFOKnxHF6M= X-Gm-Gg: AYBFou2se/21mCWVtoCI0OHC4PXwDgAvMDxw5AkYuqSdWMAU4oIT/gwx/zkVuQmM+2F srL9JON6SDYUB5yxCmrTvRaHh1F6QihajV4GWLT8eSMWnzg3Js+ITQk6EMHngrincsTkPagiQWm rleqKo97Y+2BivuSBbBwzx+9yRA4QcO6rUzYsKVEbE07uohM4t5rCNzr9xMfC5P9S6b1OeIHalH d/BLUZiIHgOylOcIo1IJQugWwOQ4GXDRNmohhAl1vRpn6snGlf5teGQORD1iuOQPBmwpR7Ahv33 vyhww86Q7yiXijNFM5L6+NMFt3JOYudTDga29yAkAGVAS1cq3flXU2v20njr366NeGB4ilQucZl Zgyn83jAVOfD4Jb2wfQe8uqaaojz7xJBmGTywKnW3JuWMbk8gN/d/NX9gaPLWuq/I2OwIxL5an2 t960k4ABE0iNpc2AxPGQBbU9tTmYVZxwIbhMPF2bmF/SLuRHZvU51C7A2WrHcEuxuL4xK07XApn J62eneOn38= X-Received: by 2002:a17:90b:4c06:b0:3a4:a2f9:f2f9 with SMTP id 98e67ed59e1d1-3a6cec2c079mr577802a91.52.1790885187917; Thu, 01 Oct 2026 13:06:27 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:5::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a6dd135d8asm39150a91.3.2026.10.01.13.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2026 13:06:26 -0700 (PDT) Date: Thu, 1 Oct 2026 13:06:26 -0700 From: Joe Damato To: hengyul@cs.unc.edu Cc: brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jirislaby@kernel.org, sdf@fomichev.me, edumazet@google.com, kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, horms@kernel.org, shuah@kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] eventpoll: return -ENOIOCTLCMD for unknown ioctl commands Message-ID: Mail-Followup-To: Joe Damato , hengyul@cs.unc.edu, brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jirislaby@kernel.org, sdf@fomichev.me, edumazet@google.com, kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, horms@kernel.org, shuah@kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260924185747.2166326-1-hengyul@cs.unc.edu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260924185747.2166326-1-hengyul@cs.unc.edu> On Thu, Sep 24, 2026 at 02:57:47PM -0400, hengyul@cs.unc.edu wrote: > From: Hengyu Liang > > Before commit 18e2bf0edf4d ("eventpoll: Add epoll ioctl for > epoll_params"), epoll files had no ioctl handler, so ioctl() on an epoll > file descriptor failed with ENOTTY. That commit introduced the > EPIOCSPARAMS and EPIOCGPARAMS commands, but ep_eventpoll_ioctl() returns > -EINVAL for any other command, so since v6.9 every other ioctl() on an > epoll file descriptor fails with EINVAL instead of ENOTTY. > > Documentation/driver-api/ioctl.rst says that an ioctl handler must > return -ENOTTY or -ENOIOCTLCMD for an unknown command, and that > returning -EINVAL there is wrong. Returning -ENOIOCTLCMD was also the > intent of the original series, whose changelog since v3 [1] says "when > an unknown ioctl is received, -ENOIOCTLCMD is returned instead of > -EINVAL as the ioctl documentation requires", and ep_eventpoll_bp_ioctl() > does return -ENOIOCTLCMD for unknown commands. However, > ep_eventpoll_ioctl() only passes EPIOCSPARAMS and EPIOCGPARAMS to it and > handles all other commands in its own default case, which returns > -EINVAL, so that path is never reached. > > This is visible to userspace. For example, isatty(), ttyname() and > tcgetattr() on an epoll file descriptor set errno to EINVAL, while they > set ENOTTY for any other file descriptor that does not refer to a > terminal, as they also did for epoll file descriptors before v6.9. > > Return -ENOIOCTLCMD from the default case, which the VFS turns into > -ENOTTY, and update the epoll_busy_poll selftest, which expected EINVAL > for an unknown command. > > [1] https://lore.kernel.org/r/20240125225704.12781-1-jdamato@fastly.com > > Fixes: 18e2bf0edf4d ("eventpoll: Add epoll ioctl for epoll_params") > Signed-off-by: Hengyu Liang > --- > fs/eventpoll.c | 2 +- > tools/testing/selftests/net/epoll_busy_poll.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Joe Damato