From: Vincent Jardin <vjardin@free.fr>
To: Conor Dooley <conor@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Charles Hsu <ythsu0511@gmail.com>,
Eduardo Valentin <eduval@amazon.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: hwmon: pmbus: mps,mpq8785: add #thermal-sensor-cells
Date: Thu, 1 Oct 2026 23:43:26 +0200 [thread overview]
Message-ID: <ar7T_u5RPVLc_MVh@L30177.local> (raw)
In-Reply-To: <20261001-hash-husband-663954aed7b0@spud>
Hi Conor,
> I don't understand this, if it has multiple sensors, each could be
> referenced by something and it would need cells. It only has single
> input, then that's the justification that needs to be provided here.
> What software does, especially in generic code, should not be used to
> justify a binding change.
>
> I checked the devices supported by the mpq8785 driver and none of them
> actually appear to have temperature inputs at all?
Right, none of them has a temperature input pin: the sensor is
internal, not an input. Each device measures the temperature of its
own die.
I hope it avoids the confusion, I'll update the commit log,
Vincent
prev parent reply other threads:[~2026-10-01 21:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 7:28 [PATCH v2 0/2] hwmon: pmbus: 0-based thermal sensor index, mps,mpq8785 #thermal-sensor-cells Vincent Jardin via B4 Relay
2026-10-01 7:28 ` [PATCH v2 1/2] hwmon: (pmbus/core) Register the thermal sensors with a 0-based index Vincent Jardin via B4 Relay
2026-10-01 7:28 ` [PATCH v2 2/2] dt-bindings: hwmon: pmbus: mps,mpq8785: add #thermal-sensor-cells Vincent Jardin via B4 Relay
2026-10-01 19:19 ` Conor Dooley
2026-10-01 21:43 ` Vincent Jardin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar7T_u5RPVLc_MVh@L30177.local \
--to=vjardin@free.fr \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eduval@amazon.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=ythsu0511@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®